Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typos in markdown files #25275

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Fix some typos in markdown files #25275

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31a78d5
Fix some typos in markdown files
qmonmert Feb 20, 2024
7db7240
Fix some typos in markdown files (after review)
qmonmert Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ARCHITECTURE.md
View file
Open in desktop
Expand Up @@ -325,7 +325,7 @@ get [Generator.END]() {

## Blueprints

Blueprint support allows to customize the generation process.
Blueprint support allows customizing the generation process.

A Blueprint package can include any number of sub-generators, each can be a replacement blueprint, a side-by-side blueprint, or a stand alone blueprint.

Expand Down
4 changes: 2 additions & 2 deletions BLUEPRINTS.md
View file
Open in desktop
@@ -1,6 +1,6 @@
# JHipster Blueprints

Blueprints allows to add new features or change current features.
Blueprints allows adding new features or change current features.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Blueprints allows adding new features or change current features.
Blueprints allow adding new features or changing current features.


## Creating a Blueprint

Expand Down Expand Up @@ -43,6 +43,6 @@ For this reason try to _avoid exact version at blueprint dependencies_ and disab
- priorities names are static constants at the generator class.
`get initializing() {}` -> `get [Generator.INITIALIZING]() {}`
Motivation can be found at https://github.com/jhipster/generator-jhipster/blob/main/rfcs/3-jhipster-rfc-unambiguous-priorities.md.
- many property migration can be warned by enabling `jhipster7Migration` feature at the constructor.
- much property migration can be warned by enabling `jhipster7Migration` feature at the constructor.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much looks weird to me, not a native speaker.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "many" sounds better, but I'm also trying to understand what the sentence should say. Are you trying to say many properties can be migrated automatically, or the deprecated ones can be printed to the console?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed properties will work but printed to console.
Won't work with the flag disabled.

- needles are not implemented in the generator base anymore.
They are injected at source object provided at some priorities and used like https://github.com/jhipster/generator-jhipster/blob/6373c9c76e57d01c4c1451a276f0d78bfbdd2c42/generators/spring-cache/generator.mts#L97-L101
2 changes: 1 addition & 1 deletion CODE_OF_CONDUCT.md
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

## Our Pledge

In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to make participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.

## Our Standards

Expand Down