Fix some typos in markdown files #25275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshima
reviewed
Feb 20, 2024
BLUEPRINTS.md
Outdated
| @@ -43,6 +43,6 @@ For this reason try to _avoid exact version at blueprint dependencies_ and disab | |||
| - priorities names are static constants at the generator class. | |||
| `get initializing() {}` -> `get [Generator.INITIALIZING]() {}` | |||
| Motivation can be found at https://github.com/jhipster/generator-jhipster/blob/main/rfcs/3-jhipster-rfc-unambiguous-priorities.md. | |||
| - many property migration can be warned by enabling `jhipster7Migration` feature at the constructor. | |||
| - much property migration can be warned by enabling `jhipster7Migration` feature at the constructor. | |||
There was a problem hiding this comment.
much looks weird to me, not a native speaker.
There was a problem hiding this comment.
I think "many" sounds better, but I'm also trying to understand what the sentence should say. Are you trying to say many properties can be migrated automatically, or the deprecated ones can be printed to the console?
There was a problem hiding this comment.
Removed properties will work but printed to console.
Won't work with the flag disabled.
mraible
reviewed
Feb 20, 2024
BLUEPRINTS.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # JHipster Blueprints | |||
|
|
|||
| Blueprints allows to add new features or change current features. | |||
| Blueprints allows adding new features or change current features. | |||
There was a problem hiding this comment.
Suggested change
| Blueprints allows adding new features or change current features. | |
| Blueprints allow adding new features or changing current features. |
mraible
previously approved these changes
Feb 20, 2024
DanielFran
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.