Update dependency webpack-dev-middleware to v5 [SECURITY]

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
webpack-dev-middleware	2.0.6 -> 5.3.4

GitHub Vulnerability Alerts

CVE-2024-29180

Summary

The webpack-dev-middleware middleware does not validate the supplied URL address sufficiently before returning the local file. It is possible to access any file on the developer's machine.

Details

The middleware can either work with the physical filesystem when reading the files or it can use a virtualized in-memory memfs filesystem.
If writeToDisk configuration option is set to true, the physical filesystem is used:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/setupOutputFileSystem.js#L21

The getFilenameFromUrl method is used to parse URL and build the local file path.
The public path prefix is stripped from the URL, and the unsecaped path suffix is appended to the outputPath:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/getFilenameFromUrl.js#L82
As the URL is not unescaped and normalized automatically before calling the midlleware, it is possible to use %2e and %2f sequences to perform path traversal attack.

PoC

A blank project can be created containing the following configuration file webpack.config.js:
module.exports = { devServer: { devMiddleware: { writeToDisk: true } } };

When started, it is possible to access any local file, e.g. /etc/passwd:
$ curl localhost:8080/public/..%2f..%2f..%2f..%2f../etc/passwd

root:x:0:0:root:/root:/bin/bash
daemon:x:1:1:daemon:/usr/sbin:/usr/sbin/nologin
bin:x:2:2:bin:/bin:/usr/sbin/nologin
sys:x:3:3:sys:/dev:/usr/sbin/nologin
sync:x:4:65534:sync:/bin:/bin/sync
games:x:5:60:games:/usr/games:/usr/sbin/nologin

Impact

The developers using webpack-dev-server or webpack-dev-middleware are affected by the issue. When the project is started, an attacker might access any file on the developer's machine and exfiltrate the content (e.g. password, configuration files, private source code, ...).

If the development server is listening on a public IP address (or 0.0.0.0), an attacker on the local network can access the local files without any interaction from the victim (direct connection to the port).

If the server allows access from third-party domains (CORS, Allow-Access-Origin: * ), an attacker can send a malicious link to the victim. When visited, the client side script can connect to the local server and exfiltrate the local files.

Recommendation

The URL should be unescaped and normalized before any further processing.

---

Release Notes

webpack/webpack-dev-middleware (webpack-dev-middleware)

v5.3.4

Compare Source

5.3.4 (2024-03-20)

Bug Fixes

• security: do not allow to read files above (#​1779) (189c4ac)

v5.3.3

Compare Source

v5.3.2

Compare Source

v5.3.1

Compare Source

v5.3.0

Compare Source

Features

• added types (a2fa77f)
• removed cjs wrapper (#​1146) (b6d53d3)

5.2.2 (2021-11-17)

Chore

• update schema-utils package to 4.0.0 version

5.2.1 (2021-09-25)

• internal release, no visible changes and features

v5.2.2

Compare Source

v5.2.1

Compare Source

• internal release, no visible changes and features

v5.2.0

Compare Source

Features

• allow array for headers option (#​1042) (5a6a3f0)

v5.1.0

Compare Source

Features

• don't read full file if Range header is present (e8b21f0)
• output more information on errors (#​1024) (7df9e44)

Bug Fixes

• reduced package size by removing mem package (#​1027) (0d55268)

v5.0.0

Compare Source

⚠ BREAKING CHANGES

• minimum supported Node.js version is 12.13.0 (#​928) (4cffeff)

v4.3.0

Compare Source

Features

• add getFilenameFromUrl to API (#​911) (1edc726)

Bug Fixes

• husky config (#​904) (8a423be)
• typo depandabot -> dependabot (#​905) (7062990)

v4.2.0

Compare Source

Features

• allow the headers option to accept function (#​897) (966afb3)

v4.1.0

Compare Source

Features

• added the stats option (376cdba)

4.0.4 (2021-01-13)

Bug Fixes

• compatibility with webpack@4 (#​816) (acdfd4d)

4.0.3 (2021-01-12)

Bug Fixes

• output stats to stdout instead stderr, how does webpack-cli, if you need hide stats from output please use { stats: false } or { stats: 'none' } (4de0f97)
• colors are working for stats (4de0f97)
• schema description (#​783) (f9ce2b2)
• skip Content-type header on unknown types (#​809) (5c9eee5)

4.0.2 (2020-11-10)

Bug Fixes

• compatibility with the headers option (#​763) (7c4cac5)

4.0.1 (2020-11-09)

Bug Fixes

• compatibility with connect (b83a1db)

v4.0.4

Compare Source

v4.0.3

Compare Source

v4.0.2

Compare Source

v4.0.1

Compare Source

v4.0.0

Compare Source

⚠ BREAKING CHANGES

• export in CommonJS format

Bug Fixes

• compatibility with new webpack@5 API (#​737) (f6054a0)
• handle the auto value of the publicPath option (9b4c5ec)
• support webpack@5 (#​702) (9ccc327)

v3.7.3

Compare Source

3.7.3 (2020-12-15)

Bug Fixes

• peer dependencies with webpack@5 (#​798) (71b2bdf)

v3.7.2

Compare Source

v3.7.1

Compare Source

v3.7.0

Compare Source

Features

• support HEAD method by default (#​398) (ec3d5eb)

v3.6.2

Compare Source

Bug Fixes

• check existence of res.getHeader and set the correct Content-Type (#​385) (56dc705)

v3.6.1

Compare Source

Bug Fixes

• do not overwrite Content-Type if header already exists (#​377) (b2a6fed)

v3.6.0

Compare Source

Features

• configurable file system via options.fs (#​370) (1762cb3)

v3.5.2

Compare Source

Bug Fixes

• don't add charset to usdz file type (#​357) (b135b3d)

v3.5.1

Compare Source

Bug Fixes

• remove querystring from filenames when writing to disk (#​361) (90d0d94)

v3.5.0

Compare Source

Bug Fixes

• middleware: do not add 'null' to Content-Type (#​355) (cf4d7a9)

Features

• allow to redefine mimeTypes (possible to use force option) (#​349) (e56a181)

v3.4.0

Compare Source

Bug Fixes

• index: don't modify the default behavior for unhandledRejection (#​340) (f0a8e3e)
• middleware: replace url-join with path.posix.join (#​334) (d75802b)

v3.3.0

Compare Source

Features

• middleware: expose the memory filesystem (response.locals.fs) (#​337) (f9a138e)

v3.2.0

Compare Source

Bug Fixes

• package: 18 security vulnerabilities (#​329) (5951de9)

Features

• middleware: add methods option (options.methods) (#​319) (fe6bb86)

v3.1.3

Compare Source

Bugfixes

• Excluded outputPath from URI escaping to fix #​297. (#​303)
• fix: fixes #​290 - MultiCompiler exception with writeToDisk (#​301)

v3.1.2

Compare Source

Updates

• refactor: use chalk from webpack-log (#​293)

v3.1.1

Compare Source

Bugfixes

• fix(package): add chalk to peerDeps (#​292)

v3.1.0

Compare Source

Bugfixes

• On windows path spaces should resolve to %20 (#​288)
• fixes #​282. credit @​cexoso. in certain edge situations res.locals is undefined (d26c67c)

Features

• Allow Writing Files to Disk (#​287)

v3.0.1

Compare Source

v3.0.0

Compare Source

Updates

• Webpack 4 (#​267)
• remove watchOffset option in favor of time-fix-plugin

Breaking Changes

• Introduces full support for webpack v4 and removes support for lesser versions.
• The watchOffset option has been removed and the README has been updated with alternative means of accomplishing the same result for this module and webpack v4.
• middleware.webpack now returns a Promise that should be handled with .then when needing to perform other actions, like adding additional middleware.

---

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.