Fixes #9183 - ConnectHandler may close the connection instead of send… #9184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing 200 OK. Delaying the call to UpstreamConnection.fillInterested() until the 200 OK response has been sent. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
added
the
Sponsored
gregw
previously approved these changes
Jan 18, 2023
| { | ||
| private final Runnable onComplete; | ||
|
|
||
| private OnCompleteListener(Runnable onComplete) |
There was a problem hiding this comment.
This feels needlessly generic? Why not just make the UpstreamConnection implement AsyncListener, then it can just call fillInterest in onComplete?
|
I tested this with airlift/airlift#1032 (using 2cdd9e26) running the test 100 times, all passed. Without this, there were 31 failures. |
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
approved these changes
Jan 18, 2023
sbordet
deleted the
fix/jetty-10-9183-connecthandler-immediate-server-close
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing 200 OK.
Delaying the call to UpstreamConnection.fillInterested() until the 200 OK response has been sent.
Signed-off-by: Simone Bordet simone.bordet@gmail.com