Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nix version as part of the nix cache key #65

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Conversation

LucilleH
Copy link
Contributor

@LucilleH LucilleH commented Jan 20, 2025

Sometimes nix ship backwards incompatible changes, which may result in devbox installation error. The following remedy is considered:

  • Add nix-version as part of the Nix cache key
  • Print out additional error message that prompts user to delete cache if needed

Addresses #64

Sorry, something went wrong.

@LucilleH LucilleH force-pushed the lucilleh--nix-version branch from df58186 to 50ecb22 Compare January 20, 2025 18:18
Signed-off-by: Lucille Hua <lucille.hua@jetpack.io>
@LucilleH LucilleH force-pushed the lucilleh--nix-version branch from 50ecb22 to c6097dd Compare January 20, 2025 18:20
@LucilleH LucilleH force-pushed the lucilleh--nix-version branch 12 times, most recently from 2ad261b to dec6301 Compare January 20, 2025 20:08
@LucilleH LucilleH changed the title Add nix version in the cache Add nix version flag as input Jan 20, 2025
@LucilleH LucilleH force-pushed the lucilleh--nix-version branch from dec6301 to e66db89 Compare January 20, 2025 21:16

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@LucilleH LucilleH force-pushed the lucilleh--nix-version branch from e66db89 to 3fb3dc9 Compare January 20, 2025 21:17
@LucilleH LucilleH force-pushed the lucilleh--nix-version branch 2 times, most recently from 7ae41be to 2ece4f9 Compare January 21, 2025 21:19
@LucilleH LucilleH force-pushed the lucilleh--nix-version branch from 2ece4f9 to f846b42 Compare January 21, 2025 21:27
@adamcstephens
Copy link

Note is that this is exposing the version for nix-installer and not nix itself.

@LucilleH LucilleH force-pushed the lucilleh--nix-version branch from 9a0ba60 to a68073b Compare January 22, 2025 17:51
@LucilleH
Copy link
Contributor Author

@adamcstephens ooof that's confusing. Ummm. I'll remove the nix-version flag for now.

@LucilleH LucilleH changed the title Add nix version flag as input Add nix version as part of the nix cache key Jan 22, 2025
@LucilleH LucilleH added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 4d0a48a Jan 22, 2025
13 checks passed
@LucilleH LucilleH deleted the lucilleh--nix-version branch January 22, 2025 18:00
github-merge-queue bot pushed a commit that referenced this pull request Jan 22, 2025
Consolidate devbox cli path. This unintended change was introduced by
#65. This is a revert on the CLI path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants