Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commits panel: add missing default sort order #4097

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

phanirithvij
Copy link
Contributor

@phanirithvij phanirithvij commented Dec 2, 2024

  • PR Description

In the commits panel, menu has only 3 sort orders, but previously git.log.order had 4 accepted values. default is missing in the new menu.

with default selected, I can see gitlogorder: default in state.yml and it function as expected in lazygit --logs

git log HEAD --oneline --pretty=format:%H%x00%at%x00%aN%x00%ae%x00%D%x00%p%x00%m%x00%s --abbrev=40 -300 --no-show-signature -- (145.062786ms)
  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

Sorry, something went wrong.

Copy link
Collaborator

@stefanhaller stefanhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this. Just one question below.

Label: "default",
OnPress: onPress("default"),
Widget: types.MakeMenuRadioButton(currentValue == "default"),
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason why you put it at the second position in the menu? I would have expected it to go last, as it's probably the least common setting to use. As far as I understand, the only reason to choose it really is when you have a huge repository and want to speed things up a bit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, moved "default" to last.

@stefanhaller stefanhaller added the bug Something isn't working label Dec 2, 2024
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
@stefanhaller stefanhaller merged commit 3a4422f into jesseduffield:master Dec 3, 2024
16 checks passed
@phanirithvij phanirithvij deleted the default-sort-order branch December 3, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants