Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh plugin #141

Merged
merged 1 commit into from Sep 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Jenkinsfile
@@ -1,4 +1,4 @@
buildPlugin(useContainerAgent: true, configurations: [
[ platform: "windows", jdk: "8" ],
[ platform: "linux", jdk: "11" ]
[platform: 'linux', jdk: 21],
[platform: 'windows', jdk: 17],
])
8 changes: 4 additions & 4 deletions pom.xml
Expand Up @@ -28,7 +28,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>4.43.1</version>
<version>4.73</version>
<relativePath />
</parent>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
Expand Down Expand Up @@ -64,15 +64,15 @@
<properties>
<changelist>999999-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
<jenkins.version>2.289.1</jenkins.version>
<jenkins.version>2.387.3</jenkins.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bump causes MockCloudTest.inbound to fail: agents keep on being provisioned, but never used. (Regardless of the jenkins.version in mock-slave-plugin/pom.xml! Discovered by bisecting bom to jenkinsci/bom#2838 and so on.) This is true as of 2.357.

INFO: Could not locate server among [http://localhost:43027/jenkins/]; waiting 10 seconds before retry
java.io.IOException: http://localhost:43027/jenkins/tcpSlaveAgentListener/ appears to be publishing an invalid X-Instance-Identity.
	at org.jenkinsci.remoting.engine.JnlpAgentEndpointResolver.resolve(JnlpAgentEndpointResolver.java:277)
	at hudson.remoting.Engine.innerRun(Engine.java:809)
	at hudson.remoting.Engine.run(Engine.java:563)

suggests jenkinsci/jenkins#6585 is involved; perhaps something weird with Maven dependency handling. Adding instance-identity as a test dep solves the issue.

<no-test-jar>false</no-test-jar>
</properties>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.289.x</artifactId>
<version>1289.v5c4b_1c43511b_</version>
<artifactId>bom-2.387.x</artifactId>
<version>2465.va_e76ed7b_3061</version>
<scope>import</scope>
<type>pom</type>
</dependency>
Expand Down