Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an URL per component #54

Merged
merged 2 commits into from May 22, 2023
Merged

Add an URL per component #54

merged 2 commits into from May 22, 2023

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented May 21, 2023

When automatic dependency updaters create PRs they tend to pick up kohsuke.org as the repository URL of the component because these are the coordinates from the parent pom.

The change proposed adds an <url> to each component to address this issue.

@NotMyFault NotMyFault requested a review from a team as a code owner May 21, 2023 18:11
enforcer-rules/pom.xml Outdated Show resolved Hide resolved
@jglick jglick added the chore label May 22, 2023
@jglick jglick merged commit 33b1a5e into jenkinsci:master May 22, 2023
2 checks passed
@jglick
Copy link
Member

jglick commented May 22, 2023

Did you need a release of this repo or something? Was not clear to me if there was any particular motivation for the sudden batch of PRs.

@NotMyFault NotMyFault deleted the add-url branch May 22, 2023 16:29
@NotMyFault
Copy link
Member Author

Was not clear to me if there was any particular motivation for the sudden batch of PRs.

Actually, this PR addresses the linking issue with renovate, the others were a mix of getting it working locally and misc chores. But I don't need a release of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants