Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set maven libs according to consumers #47

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Mar 6, 2023

use a version of maven libs that we expect to be satisfied by consumers.

cf jenkinsci/maven-hpi-plugin#440 (comment)

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jtnord jtnord requested a review from a team as a code owner March 6, 2023 12:18
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds right. I suppose this deserves a release—is there currently any known practical impact (for example on non-CD yet incrementalified plugins running mvn incrementals:reincrementalify during release)?

@jglick jglick added the bug Something isn't working label Mar 6, 2023
@jglick jglick merged commit 743384d into jenkinsci:master Mar 6, 2023
@jtnord
Copy link
Member Author

jtnord commented Mar 6, 2023

is there currently any known practical impact

I do not know of any issue in any of the plugins I am changing, as we are just blindly accepting DB updates and not using any newly introduced APIs.
So these are more "protect ourselves from future damage"
A release shouldn't harm, I prefer to release little and often

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants