Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support web components for nav and footer on jenkins.io #670

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

halkeye
Copy link
Member

@halkeye halkeye commented Jan 5, 2023

jenkins-infra/jenkins.io#5668 (comment)

makes sure property is set right for components
also don't include report a problem / improve this page (but easy to add if desired)

Copy link
Contributor

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adaptation.

site/generate-jenkins-io-template.sh Outdated Show resolved Hide resolved
site/generate-jenkins-io-template.sh Outdated Show resolved Hide resolved
site/generate-jenkins-io-template.sh Outdated Show resolved Hide resolved
site/generate-jenkins-io-template.sh Outdated Show resolved Hide resolved
site/generate-jenkins-io-template.sh Show resolved Hide resolved
halkeye and others added 4 commits January 5, 2023 02:59
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
@halkeye
Copy link
Member Author

halkeye commented Jan 5, 2023

@daniel-beck it'll be at least a day before i can poke at this again (work then personal meeting), do you want to make the changes you requested yourself?

otherwise i'll try to fix things up after everything tonight, but likely not till tomorrow afternoon for me

@daniel-beck
Copy link
Contributor

it'll be at least a day before i can poke at this again (work then personal meeting), do you want to make the changes you requested yourself?

otherwise i'll try to fix things up after everything tonight, but likely not till tomorrow afternoon for me

I don't think I'll have time before then. Thanks for checking!

* Switch to cat | sed to make it more osx portable
* Document with usage when bad parameters
@halkeye
Copy link
Member Author

halkeye commented Jan 6, 2023

Cleanup generate jenkins io template

  • Switch to cat | sed to make it more osx portable
  • Document with usage when bad parameters

I opted out of having Improve This Page and Report a Problem links on the footer but they are simple html attributes if we want them.

Copy link
Contributor

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jenkins-infra/update-center2/blob/master/src/main/java/io/jenkins/update_center/JenkinsIndexTemplateProvider.java needs to be changed as well for pages like https://updates.jenkins.io/download/war/ or https://updates.jenkins.io/download/plugins/matrix-auth/

Called via

echo "--key $SECRET/update-center.key --certificate $SECRET/update-center.cert --root-certificate $( dirname "$0" )/../resources/certificates/jenkins-update-center-root-ca-2.crt --index-template-url https://www.jenkins.io/templates/downloads/ $EXTRA_ARGS $*" >> "$MAIN_DIR"/tmp/args.lst
@Option(name = "--index-template-url", usage = "Url of a template for index files")
public String indexTemplate = null;
public void build(MavenRepository repo) throws IOException {
IndexTemplateProvider indexTemplateProvider = indexTemplate == null ? new IndexTemplateProvider() : new JenkinsIndexTemplateProvider(indexTemplate);
try (LatestLinkBuilder latestLinks = prepareLatestLinkBuilder(indexTemplateProvider)) {

@daniel-beck daniel-beck added the needs-fix This PR needs to be fixed before it can be considered mergable. label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-fix This PR needs to be fixed before it can be considered mergable.
Projects
None yet
2 participants