[LOGMGR-161] Make best attempt to only calculate caller information i… #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmlloyd Would you mind giving this a review to make sure I'm not overlooking anything? |
dmlloyd
requested changes
Jul 29, 2017
| /** | ||
| * A formatter which uses a text pattern to format messages. | ||
| */ | ||
| public class PatternFormatter extends MultistepFormatter { | ||
| private static final Pattern CALLER_CHECK_PATTERN = Pattern.compile(".*(%M|%C|%F|%L|%l).*"); |
There was a problem hiding this comment.
This pattern will miss items that have field widths, won't it? I think you might want to just query the format steps directly instead maybe.
There was a problem hiding this comment.
Good point. We may just have to add something to the FormatStep. Since we're using Java 8 now though that shouldn't be an issue.
…f the formatter being used requires it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…f the formatter being used requires it.
https://issues.jboss.org/browse/LOGMGR-161