Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compatibility with Sphinx v7.2.0 #278

Merged
merged 3 commits into from Aug 18, 2023
Merged

fix compatibility with Sphinx v7.2.0 #278

merged 3 commits into from Aug 18, 2023

Conversation

2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented Aug 18, 2023

This fixes #277 along with other problems found with v7.2.0 changes. See #277 (comment).

Copy link
Owner

@jbms jbms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@2bndy5
Copy link
Collaborator Author

2bndy5 commented Aug 18, 2023

Looks like Sphinx v7.2.0 dropped support for python v3.8. This complicates the CI a bit... My "all-or-nothing" trait wants to remove python v3.8 from the workflow, but I need to think on a better solution.

@jbms
Copy link
Owner

jbms commented Aug 18, 2023

Looks like Sphinx v7.2.0 dropped support for python v3.8. This complicates the CI a bit... My "all-or-nothing" trait wants to remove python v3.8 from the workflow, but I need to think on a better solution.

I think it might be tricky to avoid repetition entirely but this may help:
https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations

@2bndy5
Copy link
Collaborator Author

2bndy5 commented Aug 18, 2023

The exclude option should work for the unit tests, but mypy doesn't seem to understand the changes here when using python v3.8. I can type: ignore the problems until we drop 3.8 entirely or I can just skip pylint and mypy for python v3.8 in CI.

fixes #277 along with other problems found with v7.2.0 changes.

exclude sphinx7 testing with py3.8 in CI

type ignore changes for python v3.8
@2bndy5
Copy link
Collaborator Author

2bndy5 commented Aug 18, 2023

In updating the the unit tests, I found a warning about python.apigen:

tests/python_apigen_test.py: 91 warnings
  path\to\sphinx_immaterial\apidoc\python\apigen.py:1235: RemovedInSphinx80Warning: The tuple interface of ObjectMember is deprecated. Use (obj.__name__, obj.object) instead.
    members.sort(key=lambda entry: member_order.get(entry[0], float("inf")))

@2bndy5 2bndy5 merged commit c61bad9 into main Aug 18, 2023
57 checks passed
@2bndy5 2bndy5 deleted the update-sphinx-v7.2 branch August 18, 2023 06:09
@jposada202020
Copy link

Thank you @2bndy5!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with self.css_files attributes?
3 participants