New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix compatibility with Sphinx v7.2.0 #278
Conversation
00ad4be
to
9e1b4f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Looks like Sphinx v7.2.0 dropped support for python v3.8. This complicates the CI a bit... My "all-or-nothing" trait wants to remove python v3.8 from the workflow, but I need to think on a better solution. |
I think it might be tricky to avoid repetition entirely but this may help: |
9e1b4f6
to
24b98f9
Compare
The |
24b98f9
to
6d40da9
Compare
fixes #277 along with other problems found with v7.2.0 changes. exclude sphinx7 testing with py3.8 in CI type ignore changes for python v3.8
6d40da9
to
fbd0e4f
Compare
In updating the the unit tests, I found a warning about
|
26a6cad
to
c744e60
Compare
Thank you @2bndy5! |
This fixes #277 along with other problems found with v7.2.0 changes. See #277 (comment).