New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with self.css_files attributes? #277
Comments
If it is a version issue, then it would be useful to know what versions of python, sphinx, and sphinx-immaterial you are using. I suspect this is a Sphinx version problem, but I haven't looked into it yet. |
It looks like Sphinx v7.2.0 changed the |
ah so should I pin one version below that for the time being? |
I haven't done any testing (to reproduce) yet. For now, you can try pinning to |
I can confirm that In testing my fixes, I've run into some other issues about sphinx v7.2+ that will have to also be addressed in the upcoming PR:
|
The first error went away! But I think I might have hit the third error there?
|
Please use |
fixes #277 along with other problems found with v7.2.0 changes.
fixes #277 along with other problems found with v7.2.0 changes.
fixes #277 along with other problems found with v7.2.0 changes. exclude sphinx7 testing with py3.8 in CI
okay my build worked - https://github.com/flux-framework/flux-restful-api/actions/runs/5898442163/job/15999539187 - thanks for the help! I'll watch this issue for next steps. |
I have a working fix, but it needs to pass static analysis before we merge and release it. Thanks for reporting this and verifying the culprit was sphinx v7.2.0. |
Thank you!! |
fixes #277 along with other problems found with v7.2.0 changes. exclude sphinx7 testing with py3.8 in CI type ignore changes for python v3.8
fixes #277 along with other problems found with v7.2.0 changes. exclude sphinx7 testing with py3.8 in CI type ignore changes for python v3.8
Just published sphinx-immaterial v0.11.7 which includes the fix for this. |
You and @jbms are really too notch maintainers. Every time I’ve opened an issue! This is a great project and I’ll try to keep spreading the good word! |
This might be a version issue, but I just hit this:
Is it related to Python version or immaterial version? I'm not currently pinning anything. Thank you (and sorry for always opening bugs, I am terrible 😆 )
The text was updated successfully, but these errors were encountered: