Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 7.4.0 #2054

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Release 7.4.0 #2054

merged 1 commit into from
Feb 16, 2024

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Feb 16, 2024

@atugushev atugushev added the maintenance Related to maintenance processes label Feb 16, 2024
@atugushev atugushev added this to the 7.4.0 milestone Feb 16, 2024
@atugushev atugushev requested a review from a team February 16, 2024 11:25
@atugushev
Copy link
Member Author

Failing test addressed here #2055

Copy link
Contributor

@chrysle chrysle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and welcome back @atugushev!


Features:

- Allow force-enabling or force-disabling colorized output
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really start styling the changelog writing with the past tense or present simple with references to comparisons with the previous release. Like using phrases along the lines of "X now does Y". The current content reminds a Git log rather than the release notes..

@atugushev atugushev added this pull request to the merge queue Feb 16, 2024
Merged via the queue into jazzband:main with commit e3c2d86 Feb 16, 2024
36 checks passed
@atugushev atugushev deleted the release-7.4.0 branch February 16, 2024 18:34
@chrysle
Copy link
Contributor

chrysle commented Mar 5, 2024

@atugushev The release notes for 7.4.0 aren't contained in the sdist and don't show up in our stable documentation. Could it be that this was caused due to missing milestones (if so I'm sorry), or did you run the release-drafter workflow too late?

@atugushev
Copy link
Member Author

atugushev commented Mar 5, 2024

@chrysle it appears I've published the release too early, before the PR was actually merged, due to the merge queue.

Let's fix this in 7.4.1.

@webknjaz
Copy link
Member

webknjaz commented Mar 6, 2024

This is why I prefer tracking the change notes in Git 🤷‍♂️

@chrysle
Copy link
Contributor

chrysle commented Mar 6, 2024

Shall we add the towncrier Sphinx extension?

@webknjaz
Copy link
Member

webknjaz commented Mar 6, 2024

@chrysle that's not enough. My extension only shows draft fragments but Towncrier itself is not integrated here so it'd need to become a part of the release process replacing the drafter first. It's a larger change in a lot of aspects.

@chrysle
Copy link
Contributor

chrysle commented Mar 7, 2024

My extension only shows draft fragments but Towncrier itself is not integrated here so it'd need to become a part of the release process replacing the drafter first.

I'd be happy to take a look at that! Should we keep the changelog in RST, or rather use Markdown?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Related to maintenance processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants