Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display pyproject.toml's metatada parsing errors in verbose mode #1979

Merged
merged 12 commits into from
Sep 5, 2023
Merged

Display pyproject.toml's metatada parsing errors in verbose mode #1979

merged 12 commits into from
Sep 5, 2023

Commits on Sep 5, 2023

  1. Pin "build" version to ">=1.0.0" and add "pyproject_hooks" 

    Since version "1.0.0" is released on PyPI we can pass a type of
subprocess runner to "build.ProjectBuilder".
Before the type was hardcoded insude "ProjectBuilder" and was not
available to user. Therefore, whenever the error on parsing
pyproject.toml file happened, user seen only short and non-informative
`Backend subprocess exited when trying to invoke
get_requires_for_build_wheel`.
Now we can select `pyproject_hooks.default_subprocess_runner` from
`pyproject_hooks` library. This runner will throw the error directly
from toml parsing library.
    @szobov
    szobov authored and Sergei Zobov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    f003c02 View commit details
    Browse the repository at this point in the history

  2. Use "default_subprocess_runner" when execute build.ProjectBuilder 

    In order to show user the error from toml's parsing library instead of
`Backend subprocess exited when trying to invoke
get_requires_for_build_wheel`.
    @szobov
    szobov authored and Sergei Zobov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    9ac6d5f View commit details
    Browse the repository at this point in the history

  3. Update "build" and "pyproject_hooks" versions in pre-commit hook

    @szobov
    szobov authored and Sergei Zobov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    818bc8e View commit details
    Browse the repository at this point in the history

  4. Add test to check pyproject.toml error is reported

    @szobov
    szobov authored and Sergei Zobov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    f163771 View commit details
    Browse the repository at this point in the history

  5. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] authored and Sergei Zobov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    bb355d8 View commit details
    Browse the repository at this point in the history

  6. Use default_subprocess_runner only in verbose mode

    @szobov
    szobov authored and Sergei Zobov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    b2bd640 View commit details
    Browse the repository at this point in the history

  7. Refactor test 

    * No more dependencies on flit
* No network connection required
* Test verbose and non-verbose modes
    @szobov
    szobov authored and Sergei Zobov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    2d3fbf7 View commit details
    Browse the repository at this point in the history

  8. Update piptools/scripts/compile.py 

    Co-authored-by: Albert Tugushev <albert@tugushev.ru>
    @szobov @atugushev
    2 people authored and Sergei Zobov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    1398d9c View commit details
    Browse the repository at this point in the history

  9. Update tests/test_cli_compile.py 

    Co-authored-by: Albert Tugushev <albert@tugushev.ru>
    @szobov @atugushev
    2 people authored and Sergei Zobov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    91a339f View commit details
    Browse the repository at this point in the history

  10. Update tests/test_cli_compile.py 

    Co-authored-by: Albert Tugushev <albert@tugushev.ru>
    @szobov @atugushev
    2 people authored and Sergei Zobov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    e9105f3 View commit details
    Browse the repository at this point in the history

  11. Update tests/test_cli_compile.py:test_error_in_pyproject_toml 

    To check only one action: either run in verbose or non-verbose mode
    Sergei Zobov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    4557e7f View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into jazzbandgh-1711-use-default-subprocess-runner

    @atugushev
    atugushev committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    a37352e View commit details
    Browse the repository at this point in the history