Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test on pip-24.0 #2055

Merged
merged 1 commit into from Feb 16, 2024
Merged

Fix failing test on pip-24.0 #2055

merged 1 commit into from Feb 16, 2024

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Feb 16, 2024 •
edited

Proper isolation helps to fix flaky tests.

Contributor checklist
  • Included tests for the changes.
  • PR title is short, clear, and ready to be included in the user-facing changelog.
Maintainer checklist
  • Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev mentioned this pull request Feb 16, 2024
Merged
@atugushev atugushev added skip-changelog Avoid listing in changelog tests Testing and related things labels Feb 16, 2024
@atugushev atugushev mentioned this pull request Feb 16, 2024
Merged
@webknjaz webknjaz added this pull request to the merge queue Feb 16, 2024
Merged via the queue into jazzband:main with commit c8f2988 Feb 16, 2024
36 checks passed
@chrysle
Copy link
Contributor

chrysle commented Feb 16, 2024

I had the vague feeling this might help, thank you!

@atugushev atugushev deleted the fix-failing-test-on-pip-24 branch February 16, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@chrysle chrysle Awaiting requested review from chrysle

Assignees
No one assigned
Labels
skip-changelog Avoid listing in changelog tests Testing and related things
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atugushev @chrysle @webknjaz