Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Django 5.0 #583

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Test Django 5.0 #583

merged 1 commit into from
Feb 10, 2024

Conversation

adamchainz
Copy link
Contributor

Problem

Test the new version of Django that’s in beta.

Depends on #582. If you want to consider updating SaveSignalHandlingModel, we can look at that, but I really suggest that it be removed.

Solution

Added classifier to setup.py, new test environment to tox.ini, setup, and upgraded test requirements to fix some warnings.

Commandments

  • Write PEP8 compliant code.
  • Cover it with tests.
  • Update CHANGES.rst file to describe the changes, and quote according issue with GH-<issue_number>.
  • Pay attention to backward compatibility, or if it breaks it, explain why.
  • Update documentation (if relevant).

@adamchainz adamchainz changed the title Remove SaveSignalHandlingModel Test Django 5.0 Oct 26, 2023
@adamchainz
Copy link
Contributor Author

Apologies for the initially wrong title, that will have caused duplicate-looking threads on email.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74a064d) 95.10% compared to head (2708023) 95.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #583   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files           6        6           
  Lines         796      796           
=======================================
  Hits          757      757           
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanx
Copy link
Member

shanx commented Feb 7, 2024

Hey @adamchainz could you possible merge master into your branch and update the django 5.0 version to the release one. Then I would say let's go ahead with merging this PR.

tox.ini Outdated Show resolved Hide resolved
@adamchainz
Copy link
Contributor Author

adamchainz commented Feb 9, 2024

I rebased rather than merging, but yes now it’s up to date!

@shanx shanx merged commit a94d01f into jazzband:master Feb 10, 2024
9 checks passed
@shanx
Copy link
Member

shanx commented Feb 10, 2024

Hey @adamchainz thanks for the work. I just merged your PR and tried to push a new release to pypi. It seems there is a release gh workflow: https://github.com/jazzband/django-model-utils/actions/runs/7856043884/job/21438400809 but it doesn't seem to work. Do you happen to know more?

@adamchainz
Copy link
Contributor Author

I have no idea, sorry. I'm no maintainer.

@shanx
Copy link
Member

shanx commented Feb 10, 2024

hey @carljm, are you the original author of this library? After merging Adam's work I tried to push out a new release, but it looks like the release script doesn't fully work anymore: https://github.com/jazzband/django-model-utils/actions/runs/7856043884/job/21438400809 do you have any idea wat could go wrong here?

@carljm
Copy link
Collaborator

carljm commented Feb 10, 2024

@shanx I am the original author, but I have neither used the project nor been involved in maintenance for at least 8 years. I'm afraid I don't know anything about how that publish script works or what went wrong with it. I am willing to collaborate as needed in handoff steps to a responsible maintainer, but beyond that I don't have any interest in maintaining django-model-utils. Sorry!

@adamchainz adamchainz deleted the django_5.0 branch February 10, 2024 22:59
@shanx
Copy link
Member

shanx commented Feb 10, 2024

I totally understand that @carljm. I thought the spend a bit of time on this, get a release out there. But also don't have time to really dive into things. I see jazzband has the possibility to get help on a new release to pypi, I'll give that a shot. Anyway thanks for answering and have a beautiful day.

@shanx
Copy link
Member

shanx commented Feb 11, 2024

@adamchainz a release was just pushed to pypi by @charettes. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants