Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update where ConnectionDoesNotExist is imported from #566

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

mthuurne
Copy link
Contributor

Problem

ConnectionDoesNotExist does not exist in django.db.utils in django-stubs, as it was moved to django.utils.connection in Django 3.2. At some point in the future, I expect it will also only be available from its new location in Django itself.

Solution

Import it from its new location.

Commandments

  • Write PEP8 compliant code.
  • Cover it with tests.
  • Update CHANGES.rst file to describe the changes, and quote according issue with GH-<issue_number>.
  • Pay attention to backward compatibility, or if it breaks it, explain why.
  • Update documentation (if relevant).

@mthuurne mthuurne changed the title Update where ConnectionDoesNotExist is imported from Update where ConnectionDoesNotExist is imported from Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.56%. Comparing base (7b8a58b) to head (a1530ad).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files           6        6           
  Lines         768      768           
=======================================
  Hits          757      757           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mthuurne mthuurne mentioned this pull request Mar 14, 2024
CHANGES.rst Outdated Show resolved Hide resolved
It was moved to a different package in Django 3.2.
@mthuurne mthuurne force-pushed the import-ConnectionDoesNotExist branch from 3fef7cd to a1530ad Compare March 21, 2024 13:18
@foarsitter foarsitter merged commit b3e75ab into jazzband:master Mar 21, 2024
9 checks passed
@foarsitter
Copy link
Contributor

Thanks @mthuurne

@mthuurne mthuurne deleted the import-ConnectionDoesNotExist branch March 21, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants