Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: pr 11340 test flakiness #2

Commits on Apr 11, 2023

  1. linkcheck builder: close streamed HTTP response objects when no respo…

    …nse-content reads are required
    jayaddison committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    f538440 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    524368f View commit details
    Browse the repository at this point in the history
  3. refactor: use requests.Response objects as context managers during li…

    …nkchecking
    
    This ensures that the close method of the response is called when the response variable goes out-of-scope
    jayaddison committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    9ec505f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c708cc9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4eb7896 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    95dd08a View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2023

  1. Configuration menu
    Copy the full SHA
    2aceccc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a3a340b View commit details
    Browse the repository at this point in the history
  3. Revert "refactor: use requests.Response objects as context managers d…

    …uring linkchecking"
    
    This reverts commit 9ec505f.
    jayaddison committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    692fdef View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6fd82b3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    98df982 View commit details
    Browse the repository at this point in the history
  6. Revert "Fixup: close the response after an HTTP HEAD response is rece…

    …ived"
    
    This reverts commit 98df982.
    jayaddison committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    ec415ea View commit details
    Browse the repository at this point in the history
  7. Revert "Fixup: do not close the response before anchor-checking has b…

    …een performed"
    
    This reverts commit 6fd82b3.
    jayaddison committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    5769478 View commit details
    Browse the repository at this point in the history
  8. Revert "Revert "refactor: use requests.Response objects as context ma…

    …nagers during linkchecking""
    
    This reverts commit 692fdef.
    jayaddison committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    8269c6d View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Configuration menu
    Copy the full SHA
    ad12d25 View commit details
    Browse the repository at this point in the history
  2. tests: linkcheck builder: update test webserver handlers from HTTP/1.…

    …0 protocol (default) to HTTP/1.1
    jayaddison committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    7162671 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cbedb4b View commit details
    Browse the repository at this point in the history
  4. Unit tests: linkcheck: ConnectionResetHandler: close the connection b…

    …y setting the 'close_connection' handler attribute instead of calling connection.close
    
    Ref: https://docs.python.org/3/library/http.server.html#http.server.BaseHTTPRequestHandler.close_connection
    jayaddison committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    cd756b4 View commit details
    Browse the repository at this point in the history
  5. Unit tests: linkcheck: make_redirect_handler: send zero-valued conten…

    …t-length response header during redirects
    jayaddison committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    687ea43 View commit details
    Browse the repository at this point in the history
  6. Unit tests: linkcheck: capture_headers_handler: perform header captur…

    …e after headers have all been configured, but before they may have been flushed to the client
    jayaddison committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    acec710 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e304062 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3bf835c View commit details
    Browse the repository at this point in the history
  9. Unit tests: linkcheck: configure a single linkcheck worker during 'te…

    …st_defaults' test case
    
    With thanks to @picnixz for mentioning this configuration setting: sphinx-doc#11324 (comment)
    jayaddison committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    4305d11 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4e07b90 View commit details
    Browse the repository at this point in the history
  11. Revert "Revert "linkcheck builder: begin using session-based HTTP req…

    …uests""
    
    This reverts commit 3bf835c.
    jayaddison committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    5d32e46 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    08107c2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    80f8a96 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    af477d6 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    8c22165 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    72e80b7 View commit details
    Browse the repository at this point in the history
  17. type hinting: ignore warnings related to Session.get and Session.head…

    … methods since their superclass does not provide type hints
    jayaddison committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    893a4d9 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    ac1ce7b View commit details
    Browse the repository at this point in the history
  19. Revert "Naive fixup: add session request support to ImageDownloader c…

    …lass"
    
    This reverts commit ac1ce7b.
    jayaddison committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    01d9136 View commit details
    Browse the repository at this point in the history
  20. Revert "Naive fixup: add basic session request support to Intersphinx…

    … extension"
    
    This reverts commit af477d6.
    jayaddison committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    6a766ec View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    39d0eb6 View commit details
    Browse the repository at this point in the history
  22. Revert "Fixup: update requests mocking in 'test_build.py' unit test m…

    …odule"
    
    This reverts commit 8c22165.
    jayaddison committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    ac72068 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    3a8c8a5 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Privatise

    AA-Turner committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    3aa4b40 View commit details
    Browse the repository at this point in the history
  2. Privatise

    AA-Turner committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    eca898e View commit details
    Browse the repository at this point in the history
  3. Revert "Unit tests: linkcheck: capture_headers_handler: perform heade…

    …r capture after headers have all been configured, but before they may have been flushed to the client"
    
    This reverts commit acec710.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    31ca85b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    89442fc View commit details
    Browse the repository at this point in the history
  5. Merge branch 'issue-11317/linkcheck-close-streamed-http-connections' …

    …into issue-11324/linkcheck-sessioned-requests
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    f7caae0 View commit details
    Browse the repository at this point in the history
  6. Unit tests: linkcheck: capture_headers_handler: relocate the (client)…

    … header capture to before any server-side communication has been initiated by the handler
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    4d485ae View commit details
    Browse the repository at this point in the history
  7. linkcheck builder: enable streaming mode (no-immediate-content-read) …

    …during HTTP HEAD requests
    
    This shouldn't theoretically make much of a difference for HTTP HEAD requests, since they're not expected to include body content in the response data.  In practice, I think this may resolve some test flakiness for sphinx.
    
    Enabling streaming mode has to be done carefully to ensure that the connection is returned to the pool; we are using a context-manager when making requests here, so this should be safe.  Ref: https://requests.readthedocs.io/en/latest/user/advanced/#body-content-workflow
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    599f105 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2ee5cc6 View commit details
    Browse the repository at this point in the history
  9. Unit tests: linkcheck: send zero-valued Content-Length header for uns…

    …upported-method response in redirect handler
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    ac2baaa View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    88fb703 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2cad628 View commit details
    Browse the repository at this point in the history
  12. Revert "Unit tests: linkcheck: send Content-Length header in all HTTP…

    …/1.1 test server responses"
    
    This reverts commit 2cad628.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    a7b44bf View commit details
    Browse the repository at this point in the history
  13. Revert "Revert "Unit tests: linkcheck: send Content-Length header in …

    …all HTTP/1.1 test server responses""
    
    This reverts commit a7b44bf.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    81e554e View commit details
    Browse the repository at this point in the history
  14. Revert "Unit tests: linkcheck: send Content-Length header in all HTTP…

    …/1.1 test server responses"
    
    This reverts commit 2cad628.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    70b9c30 View commit details
    Browse the repository at this point in the history
  15. Revert "Revert "Unit tests: linkcheck: send Content-Length header in …

    …all HTTP/1.1 test server responses""
    
    This reverts commit a7b44bf.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    04d10f8 View commit details
    Browse the repository at this point in the history
  16. Unit tests: linkcheck: fixup: InfiniteRedirectOnHeadHandler: send Con…

    …tent-Header before calling end-of-headers method
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    9ade882 View commit details
    Browse the repository at this point in the history
  17. Unit tests: linkcheck: further increase for timeout in 'linkcheck-loc…

    …alserver-warn-redirects' conf
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    d28e9d6 View commit details
    Browse the repository at this point in the history
  18. Revert "Unit tests: linkcheck: send Content-Length header in all HTTP…

    …/1.1 test server responses"
    
    This reverts commit 2cad628.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    5aaaeb4 View commit details
    Browse the repository at this point in the history
  19. Revert "Revert "Unit tests: linkcheck: send Content-Length header in …

    …all HTTP/1.1 test server responses""
    
    This reverts commit a7b44bf.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    0ed88b4 View commit details
    Browse the repository at this point in the history
  20. test_linkcheck_allowed_redirects: reduce the number of HTTP round-tri…

    …ps by enabling support for HEAD requests
    
    This is intended to reduce the number of HTTP requests within this particular test to closer-to-the-norm compared to other tests within the test_build_linkcheck.py module; this test has been failing intermittently and it seems possible that timeouts due to HTTP roundtrip traffic are a contributing factor.
    
    (cherry picked from commit c2d5bef)
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    e01937e View commit details
    Browse the repository at this point in the history
  21. Revert "Unit tests: linkcheck: send Content-Length header in all HTTP…

    …/1.1 test server responses"
    
    This reverts commit 2cad628.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    93490f0 View commit details
    Browse the repository at this point in the history
  22. Revert "Revert "Unit tests: linkcheck: send Content-Length header in …

    …all HTTP/1.1 test server responses""
    
    This reverts commit a7b44bf.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    3793f3b View commit details
    Browse the repository at this point in the history
  23. Revert "Unit tests: linkcheck: send Content-Length header in all HTTP…

    …/1.1 test server responses"
    
    This reverts commit 2cad628.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    203763f View commit details
    Browse the repository at this point in the history
  24. Revert "Revert "Unit tests: linkcheck: send Content-Length header in …

    …all HTTP/1.1 test server responses""
    
    This reverts commit a7b44bf.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    2babbe8 View commit details
    Browse the repository at this point in the history
  25. Revert "Revert "Revert "Unit tests: linkcheck: send Content-Length he…

    …ader in all HTTP/1.1 test server responses"""
    
    This reverts commit 2babbe8.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    d7983d0 View commit details
    Browse the repository at this point in the history
  26. Revert "Unit tests: linkcheck: send zero-valued Content-Length header…

    … for unsupported-method response in redirect handler"
    
    This reverts commit ac2baaa.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    fb2e944 View commit details
    Browse the repository at this point in the history
  27. Revert "linkcheck builder: enable streaming mode (no-immediate-conten…

    …t-read) during HTTP HEAD requests"
    
    This reverts commit 599f105.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    030be8b View commit details
    Browse the repository at this point in the history
  28. Revert "Revert "Unit tests: linkcheck: send zero-valued Content-Lengt…

    …h header for unsupported-method response in redirect handler""
    
    This reverts commit fb2e944.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    53d9493 View commit details
    Browse the repository at this point in the history
  29. Revert "Revert "Revert "Revert "Unit tests: linkcheck: send Content-L…

    …ength header in all HTTP/1.1 test server responses""""
    
    This reverts commit d7983d0.
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    8375bdb View commit details
    Browse the repository at this point in the history
  30. Merge branch 'issue-11324/linkcheck-sessioned-requests' into issue-11…

    …324/linkcheck-sessioned-requests-test-flakiness-testing
    jayaddison committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    b946162 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2023

  1. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    e82aea5 View commit details
    Browse the repository at this point in the history
  2. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    8cb0e8c View commit details
    Browse the repository at this point in the history
  3. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    b8c26a6 View commit details
    Browse the repository at this point in the history
  4. Revert "Unit tests: linkcheck: send Content-Length header in all HTTP…

    …/1.1 test server responses"
    
    This reverts commit 2cad628.
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    adbd334 View commit details
    Browse the repository at this point in the history
  5. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    8467293 View commit details
    Browse the repository at this point in the history
  6. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    bea4776 View commit details
    Browse the repository at this point in the history
  7. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    7448c23 View commit details
    Browse the repository at this point in the history
  8. Revert "Unit tests: linkcheck: send zero-valued Content-Length header…

    … for unsupported-method response in redirect handler"
    
    This reverts commit ac2baaa.
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    6f49c47 View commit details
    Browse the repository at this point in the history
  9. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    bafccbb View commit details
    Browse the repository at this point in the history
  10. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    2092ddf View commit details
    Browse the repository at this point in the history
  11. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    820bca1 View commit details
    Browse the repository at this point in the history
  12. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    0305d07 View commit details
    Browse the repository at this point in the history
  13. Revert "Unit tests: linkcheck: further increase for timeout in 'linkc…

    …heck-localserver-warn-redirects' conf"
    
    This reverts commit d28e9d6.
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    5629d1a View commit details
    Browse the repository at this point in the history
  14. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    026064d View commit details
    Browse the repository at this point in the history
  15. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    67d382e View commit details
    Browse the repository at this point in the history
  16. linkcheck builder: experiment: ensure that any error exception from a…

    …n initial HTTP HEAD request is out-of-scope before performing a fallback HTTP GET request (ensuring that the associated 'response' object's resources can be collected)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    d6f29be View commit details
    Browse the repository at this point in the history
  17. Revert "test_linkcheck_allowed_redirects: reduce the number of HTTP r…

    …ound-trips by enabling support for HEAD requests"
    
    This reverts commit e01937e.
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    4108d60 View commit details
    Browse the repository at this point in the history
  18. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    edb0981 View commit details
    Browse the repository at this point in the history
  19. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    fb61370 View commit details
    Browse the repository at this point in the history
  20. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    43ed3a8 View commit details
    Browse the repository at this point in the history
  21. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    f23752e View commit details
    Browse the repository at this point in the history
  22. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    bee3042 View commit details
    Browse the repository at this point in the history
  23. CI: empty commit to re-run tests (an attempt to gain confidence that …

    …test flakiness has been resolved)
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    3d7aa20 View commit details
    Browse the repository at this point in the history
  24. unit tests: linkcheck: begin using a thread-safe collections.deque in…

    …stance to record received client headers
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    c3aab47 View commit details
    Browse the repository at this point in the history
  25. Merge branch 'issue-11348/flaky-test-linkcheck-client-header-collecti…

    …on' into issue-11324/linkcheck-sessioned-requests-test-flakiness-testing
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    5c0d611 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    e232058 View commit details
    Browse the repository at this point in the history
  27. Merge branch 'issue-11348/flaky-test-linkcheck-client-header-collecti…

    …on' into issue-11324/linkcheck-sessioned-requests-test-flakiness-testing
    jayaddison committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    2017e71 View commit details
    Browse the repository at this point in the history