Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: issue 11299 replicability #1

Closed

Conversation

jayaddison
Copy link
Owner

@jayaddison jayaddison commented Apr 14, 2023

Using this branch to perform repeat continuous integration testing for potential flaky-test fixes.

Tally Issue encountered Issue not encountered
Without sphinx-doc#11323 2 48
With sphinx-doc#11323 0 50

Test failures:

…ps by enabling support for HEAD requests

This is intended to reduce the number of HTTP requests within this particular test to closer-to-the-norm compared to other tests within the test_build_linkcheck.py module; this test has been failing intermittently and it seems possible that timeouts due to HTTP roundtrip traffic are a contributing factor.
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
@jayaddison
Copy link
Owner Author

The failure at https://github.com/jayaddison/sphinx/actions/runs/4697985339/jobs/8329708670?pr=1#step:10:2447 was a timeout in the test_raw_node test case, seeming to indicate that the problem is in fact not specific to the test_linkcheck_allowed_redirects test.

…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
@jayaddison
Copy link
Owner Author

Why would sphinx-doc#11323 make any difference to the result of other unrelated unit tests?

And in particular, why would it reduce the number of timeouts encountered by HTTP API clients during those other tests?

It doesn't seem to make sense. I think that the lack of test failures so far here when running with the fix applied must be a coincidence. I'll continue a few more rounds of testing.

…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
@jayaddison
Copy link
Owner Author

Hmm, this is proving fairly tricky to replicate. I wonder if any/some of the failures could've been due to something environmental like resource contention (limited CPU time available on the GitHub Actions runners available to the tests when they were running, for example) and not a code-related issue at all. Not too far from a roundish number of 100 evaluations currently, so at that point I'll probably call this complete, regardless of whether it provides much additional information by then.

…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
…f HTTP round-trips by enabling support for HEAD requests""

This reverts commit 08d2ffb.

(cherry picked from commit 3de9337)
…ound-trips by enabling support for HEAD requests"

This reverts commit c2d5bef.

(cherry picked from commit 08d2ffb)
@jayaddison
Copy link
Owner Author

After 100 experimental evaluations (each involving running the tests across a matrix of three Python versions, two DocUtils versions, and doubled for good measure (one GitHub Actions push event and one pull_request each)), the only failures that occurred were without the fix applied.

Despite that, I don't see any reason why the fix should improve the situation here; my preference is to increase the timeout threshold in the linkcheck tests instead.

@jayaddison jayaddison closed this Apr 14, 2023
@jayaddison jayaddison deleted the issue-11299/reduce-flaky-test-request-roundtrips-testing branch April 14, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant