New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: restore main
field of package.json for environments that do not support exports
field
#526
feat: restore main
field of package.json for environments that do not support exports
field
#526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the docs about this topic. Just remove them. Also please make a new issue to remove main
once the Metro issue is closed. Thanks!
I missed the workaround in the README! (sorry 💦 ) So I would like this PR to be merged for fixing the errors. I will update the docs and make the new issue.
|
@morishin ok thanks |
main
field of package.json for environments that do not support exports
fieldmain
field of package.json for environments that do not support exports
field
Would it be possible to expand that to current tooling that is still using main? I'm still waiting on the resolve package to add support for parsing exports for example. |
@ismay yep please create that issue or chime into existing one if there, thanks! |
I tried to use
graphql-request
for a ReactNative app. But build errors occured because metro bundler unfortunately does not supportexports
field yet...So I would like to restore
main
field which was dropped by facebook/metro#670.This change would only restore backward compatibility and would not have any bad effect on modern environments.