Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove main field of package.json in future #532

Closed
morishin opened this issue May 23, 2023 · 1 comment · Fixed by #607
Closed

Remove main field of package.json in future #532

morishin opened this issue May 23, 2023 · 1 comment · Fixed by #607
Labels
breaking Issues or PRs that contain breaking changes type/feat

Comments

@morishin
Copy link
Contributor

Also please make a new issue to remove main once the Metro issue is closed. #526 (review)

The main field in package.json was restored by #526 for backward compatibility.
We hope facebook/metro#670 will be closed and we can drop the main field again.
@jasonkuhrt
Copy link
Owner

Thanks @morishin!

@jonkoops jonkoops added the breaking Issues or PRs that contain breaking changes label Oct 29, 2023
@jonkoops jonkoops mentioned this issue Oct 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Issues or PRs that contain breaking changes type/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: remove support for CommonJS jonkoops/graphql-request
3 participants
@jasonkuhrt @jonkoops @morishin