Replace deprecated ssl.wrap_socket with SSLContext.wrap_socket #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update examples in connection.py docs
bswck
approved these changes
Mar 27, 2024
|
The coverage failures are fine - these lines were added to a script that already wasn't being tested in that code, so I'll ignore the failure. Thanks for the contrib! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssl.wrap_socket() was also removed in Python 3.12, so this makes ssl-cat.py work with 3.12.
I prefer this fix, but I also have a branch where I changed the library code to directly work with SSLContext.wrap_socket but it's a breaking change, since then ssl.wrap_socket() will no longer work: main...StareInTheAir:irc-fork:feature/ssl-context-wrap-socket-lib
Please let me know if I should open a PR for that branch instead
This PR is backwards compatible since it's only client-side.
Resolves #216