Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pydantic
requires Rust, which is not available on Cygwin. Pre-compiled wheels might also be not available on non-{windows,linux,mac} platforms #195.In this PR, I propose removing the dependency on
pydantic
to avoid the installation problems caused by the lack of pre-compiled wheels and/or the Rust toolchain in some platforms (e.g. Cygwin or FreeBSD).The objective is to make improve the viability of
inflect
(and other packages that depend on it) as a OS agnostic library.Main changes in implementation
pydantic.validate_call
decorator with explicit calls to_validate_type
, which is based onisinstance
.Main caveats
number_to_words
, I just introduced validation for thenum
argument, not for the other ones. Please let me know if it would be relevant to add validations for the other arguments too.pydantic...ValidationError
will not raiseTypeError(f"{obj!r} given, but expecting {types}")
.