-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return errors from span processor creation #6488
Conversation
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6488 +/- ##
==========================================
- Coverage 96.30% 96.25% -0.06%
==========================================
Files 372 372
Lines 21277 21282 +5
==========================================
- Hits 20491 20485 -6
- Misses 601 609 +8
- Partials 185 188 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -36,7 +36,7 @@ type SpanHandlers struct { | |||
} | |||
|
|||
// BuildSpanProcessor builds the span processor to be used with the handlers | |||
func (b *SpanHandlerBuilder) BuildSpanProcessor(additional ...ProcessSpan) processor.SpanProcessor { | |||
func (b *SpanHandlerBuilder) BuildSpanProcessor(additional ...ProcessSpan) (processor.SpanProcessor, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yurishkuro why are we adding error to the signature here if this function isn't returning an error? is there going to be a follow-up PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes - as explained in the PR description, introducing OTEL components will introduce errors
## Which problem is this PR solving? - Part of jaegertracing#6487 ## Description of the changes - Creation of exporterhelper may result in an error, so extend the processor construction signature to return the error. ## How was this change tested? - CI Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: adityachopra29 <adityachopra2912@gmail.com>
Which problem is this PR solving?
Description of the changes
How was this change tested?