Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics endpoint #15

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Add metrics endpoint #15

merged 4 commits into from
Oct 6, 2023

Conversation

jadolg
Copy link
Owner

@jadolg jadolg commented Sep 10, 2023

No description provided.

@jadolg jadolg self-assigned this Sep 10, 2023
@jadolg jadolg linked an issue Sep 10, 2023 that may be closed by this pull request
@jadolg
Copy link
Owner Author

jadolg commented Sep 10, 2023

It seems we have a security issue with the Prometheus client_golang lib.
I opened a PR there with the needed changes prometheus/client_golang#1342
Lets wait to see if it gets merged and deployed.

@jadolg
Copy link
Owner Author

jadolg commented Oct 6, 2023

The issue doesn't seem to be important enough so the fix is not getting attention.
I'll merge and deal with this later.
There's no clear attack vector anyway.

@jadolg jadolg merged commit b6ae7c4 into main Oct 6, 2023
4 of 5 checks passed
@jadolg jadolg deleted the add-metrics branch October 6, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics
1 participant