Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travelcost values for sliding doors to prevent walking through frame posts #1991

Merged

Conversation

ShishkinP
Copy link
Contributor

@ShishkinP ShishkinP commented May 10, 2024

If a wall adjacent to a sliding door doesn't exist (blown up or never was even placed in the map editor), characters can move through a doorframe post in 2 directions out of 4. Single doors don't have this problem - all 4 directions are blocked.
slidingdoorbug1
slidingdoorbug3
slidingdoorbug2
slidingdoorbug4
To fix this, 2 more movement cost values are added for both right- and left-oriented sliding doors and their both doorframe posts. I think I tested all there is to test including the consequences of destroying the doors themselves.
Savefile with a merc with 3 TNTs in the hospital map: https://disk.yandex.ru/d/V50LKTdY1keq0A

@lynxlynxlynx lynxlynxlynx added this to the v0.22 milestone May 15, 2024
@lynxlynxlynx lynxlynxlynx added bug vanilla Bugs that exist in the original JA2 game labels May 15, 2024
@lynxlynxlynx
Copy link
Member

LGTM, thanks!

@lynxlynxlynx lynxlynxlynx merged commit 32a5caa into ja2-stracciatella:master May 15, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug vanilla Bugs that exist in the original JA2 game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants