Improve loading strings from EDT files #1988
Conversation
This commit adds the following: 1. A new interface IEDT. This very simple interface has just one method to get a single string from an EDT file. 2. Class ClassicEDT is a helper class for files in the original .edt format. It does not do much, it simply opens the file and takes care of offset calculations. 3. Class JsonEDT is only available for mods via the ModPackContentManager. It uses a classic .edt file as a fallback option and allows to override individual strings with entries taken from a .json file. 4. Class EDTFile is the intended replacement for the current loadEncryptedString calls. It contains the details needed to interpret the layout of the supported .edt files.
|
Here is a screenshot to demonstrate that this addresses the problem mentioned in #1986. It's possible to fill the entire available area with text now.
|
lynxlynxlynx
added
the
externalization
|
Nice work! I only noticed a blog/blob typo, but have no comments on the architecture. Is there any reason we wouldn't use the same implementation for the existing users, as a second step to this? |
|
VanillaItems also uses a schema so that would require a bit more work and that's time that is probably better spent adding more .edt files. The DefaultContentManager version of loadDialogQuoteFromFile could easily be converted but the ModPack version expects the .edt.json file to contain a complete set of all quotes in that file so that it can cache these strings so that would require a redesign that probably wouldn't have much benefit. |
Also changes this method to no longer return a pointer to a string which simplifies its only user, GetDialogue().
|
Thanks! |
This commit adds the following:
As Derek mentioned, the quote files in the mercedt folder were already done and selaux added support for itemdesc.edt in #1575. This PR adds aimbios.edt, mercbios.edt and help.edt and should be flexible enough for the remaining files in binarydata.
This seems to work but I'm marking it as a draft because I'd like to get some feedback about the general design and more testing first. Don't forget to enable the test-json-dialogs mod to see some changes.