Config and save directories according to XDG Base Directory specification #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
It should be that now but I broke some tests for appveyor and I don't know how to fix them. It works on my machine though. |
| @@ -10,7 +10,13 @@ const STRACCIATELLA_HOME_DIR_NAME: &str = "JA2"; | |||
| /// Find ja2 stracciatella configuration directory inside the user's home directory or the android app dir | |||
| pub fn find_stracciatella_home() -> Result<PathBuf, String> { | |||
| #[cfg(not(target_os = "android"))] | |||
| let base = dirs::home_dir(); | |||
| let base: Option<PathBuf>; | |||
| if Path::new(&format!("{}/{}", std::env::var("HOME").unwrap(), STRACCIATELLA_HOME_DIR_NAME)).is_dir() { | |||
There was a problem hiding this comment.
isn't it broken here now, with the latest change? ~/ja2 is not a good dir.
|
Hey @bugwrit3r, any plans on finishing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config directory gets created in $XDG_CONFIG_HOME/.ja2 or $HOME/.config/.ja2 if variable is unset.
Save directory gets created in $XDG_DATA_HOME/,ja2 or $HOME/.local/.share/.ja2 if variable is unset.
$HOME/.ja2 is used if it's already present.