Update reporting functionality #32
Merged
+97
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogermparent
changed the title
rogermparent
commented
Jan 27, 2023
Comment on lines
+19
to
+48
| owner: | ||
| description: | ||
| The owner of repository to operate on if the event doesn't include it | ||
| required: false | ||
| type: string | ||
| default: '${{ github.event.repository.owner.login }}' | ||
| repo: | ||
| description: | ||
| The repository to operate on if the event doesn't include it | ||
| required: false | ||
| type: string | ||
| default: '${{ github.event.repository.name }}' | ||
| label: | ||
| description: | ||
| The label that will be used to identify existing link-check reports to | ||
| edit | ||
| required: false | ||
| type: string | ||
| default: link-check-all | ||
| labels: | ||
| description: | ||
| The labels that will be assigned to issues created by this workflow | ||
| required: false | ||
| type: string | ||
| default: link-check-all | ||
| title: | ||
| description: The title of the issue created by this workflow | ||
| required: false | ||
| type: string | ||
| default: 'Link Checker Report' |
There was a problem hiding this comment.
These are from the download link checker action, mostly needed to find existing Issues
rogermparent
commented
Jan 27, 2023
Comment on lines
+1
to
+3
| fileIncludePatterns: | ||
| - ./test/* | ||
|
|
There was a problem hiding this comment.
This will be helpful for general testing
rogermparent
commented
Jan 27, 2023
Comment on lines
-45
to
+48
| run: cml send-comment --pr --update ${{ inputs.outputFile }} | ||
| run: cml comment update --watermark-title="Link Check Report" ${{ inputs.outputFile }} |
There was a problem hiding this comment.
Updated CML syntax
rogermparent
commented
Jan 27, 2023
Comment on lines
+20
to
+23
| config: | ||
| type: 'string' | ||
| description: 'The path to the link-check config file' | ||
| default: 'config/link-check/config.yml' |
There was a problem hiding this comment.
Saw this was hard-coded in this workflow while the all workflow is configurable, copied here
Merged
rogermparent
referenced
this pull request
in iterative/mlem.ai
Feb 7, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [iterative/link-check](https://togithub.com/iterative/link-check) | action | minor | `v0.13.2` -> `v0.14.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | repo-link-check | dependencies | minor | [`^0.13.0` -> `^0.14.0`](https://renovatebot.com/diffs/npm/repo-link-check/0.13.0/0.14.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>iterative/link-check</summary> ### [`v0.14.0`](https://togithub.com/iterative/link-check/releases/tag/v0.14.0) [Compare Source](https://togithub.com/iterative/link-check/compare/v0.13.2...v0.14.0) ##### What's Changed - Update reporting functionality by [@​rogermparent](https://togithub.com/rogermparent) in [https://github.com/iterative/link-check/pull/32](https://togithub.com/iterative/link-check/pull/32) **Full Changelog**: iterative/link-check@v0.13.2...v0.14.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/iterative/mlem.ai). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMjQuMiIsInVwZGF0ZWRJblZlciI6IjM0LjEyNC4yIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates reporting for both the diff and whole-site link checks
The diff check has been changed to replace its deprecated
send-commentsyntax with currentcml commentsyntaxThe whole site check has the Issue report functionality from dvc.org's download link checker added to it. I didn't use CML here because it seems that CML can't make Issues, only Comments or PRs.
This action also closes the report ticket if it finds all links passed.
Example report Issue at #36