Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use StringMatch instead deprecated matcher types #45132

Closed
wants to merge 2 commits into from
Closed

Use StringMatch instead deprecated matcher types #45132

wants to merge 2 commits into from

Conversation

kebe7jun
Copy link
Member

Please provide a description of this PR:

HeaderMatcher_PrefixMatch and etc are deprecated.

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Ambient
  • Configuration Infrastructure
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Policies and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@kebe7jun kebe7jun requested a review from a team as a code owner May 25, 2023 07:44
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 25, 2023
@kebe7jun kebe7jun marked this pull request as draft May 25, 2023 07:49
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label May 25, 2023
@kebe7jun kebe7jun added the release-notes-none Indicates a PR that does not require release notes. label May 25, 2023
@kebe7jun kebe7jun force-pushed the fix/remove-deprecated-matcher branch from b4c9d98 to 64fe62b Compare May 25, 2023 07:59
@kebe7jun kebe7jun marked this pull request as ready for review May 25, 2023 08:15
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label May 25, 2023
@istio-testing
Copy link
Collaborator

istio-testing commented May 25, 2023 •
edited

@kebe7jun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests-arm64_istio 64fe62b link true /test unit-tests-arm64
unit-tests_istio 64fe62b link true /test unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kebe7jun
Copy link
Member Author

Wait for grpc/grpc-go#6313

@kebe7jun kebe7jun marked this pull request as draft May 25, 2023 08:54
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label May 25, 2023
@wulianglongrd
Copy link
Member

If I recall correctly, the test case here will still fail even though grpc/grpc-go#6313 has been merged. Because grpc-go only implements StringMatch for RDS, not including RBAC's StringMatch(see here).

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Aug 4, 2023
@howardjohn
Copy link
Member

grpc/grpc-go#6419 - may be ok now?

@howardjohn howardjohn reopened this Aug 4, 2023
@wulianglongrd
Copy link
Member

i think yes

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 21, 2023
@istio-testing
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Sep 4, 2023
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2023-08-05. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while needs-rebase Indicates a PR needs to be rebased before being merged release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kebe7jun @istio-testing @wulianglongrd @howardjohn @istio-policy-bot