Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PeerAuthentication docs #3184

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update PeerAuthentication docs #3184

wants to merge 5 commits into from
+28 −15

Conversation

craigbox
Copy link
Contributor

@craigbox craigbox commented May 9, 2024 •
edited

Given we seem to have decided to keep PeerAuthentication around in ambient mode, update the docs to remove the warning, and add the caveat you can't DISABLE mTLS any more.

(This may or may not be the project's decision.)

@craigbox craigbox requested a review from a team as a code owner May 9, 2024 03:48
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 9, 2024
@craigbox craigbox added the release-notes-none Indicates a PR that does not require release notes. label May 9, 2024
@craigbox craigbox mentioned this pull request May 9, 2024
Closed
howardjohn
howardjohn reviewed May 9, 2024
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM

security/v1/peer_authentication.proto Outdated Show resolved Hide resolved
@craigbox craigbox added the cherrypick/release-1.22 Set this label on a PR to auto-merge it to the release-1.22 branch label May 16, 2024
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2024
hzxuzhonghu
hzxuzhonghu reviewed May 17, 2024
View reviewed changes
security/v1/peer_authentication.proto Outdated
// In ambient mode, security is transparently enabled for a pod by the ztunnel node agent.
// (Traffic between proxies uses the HBONE protocol, which includes encryption with mTLS.)
// Because of this, `DISABLE` mode is not supported.
// `STRICT` mode is useful to ensure that connections that bypass the mesh are not possible.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we say this api doesnot apply to ambient mode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does apply to ambient mode though, just not with DISABLE mode, AIUI. @keithmattix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this. This is correct

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label May 20, 2024
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR needs to be rebased before being merged size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2024
@craigbox
Copy link
Contributor Author

rebased and hopefully ready for proper merging

@craigbox
Copy link
Contributor Author

@howardjohn for formal approval

@craigbox
Copy link
Contributor Author

the gencheck test is asking me to patch a file which doesn't exist any more, since #3188 made the files into aliases.

However, make gen is failing too:

craigbox@solo-system-craigbox:~/Documents/Projects/istio-api$ make gen
./clean.sh
./gen.sh
2024/05/31 14:27:15 Generating istio.security.v1beta1.RequestAuthentication
2024/05/31 14:27:15 Generating istio.networking.v1alpha3.WorkloadGroup
2024/05/31 14:27:15 Generating istio.networking.v1alpha3.VirtualService
2024/05/31 14:27:15 Generating istio.networking.v1alpha3.DestinationRule
2024/05/31 14:27:15 Generating istio.networking.v1alpha3.WorkloadEntry
2024/05/31 14:27:15 Generating istio.networking.v1alpha3.Sidecar
2024/05/31 14:27:15 Generating istio.networking.v1beta1.ProxyConfig
2024/05/31 14:27:15 Generating istio.security.v1beta1.AuthorizationPolicy
2024/05/31 14:27:15 Generating istio.networking.v1alpha3.ServiceEntry
2024/05/31 14:27:15 Generating istio.networking.v1alpha3.EnvoyFilter
2024/05/31 14:27:15 Generating istio.security.v1beta1.PeerAuthentication
2024/05/31 14:27:15 Generating istio.extensions.v1alpha1.WasmPlugin
2024/05/31 14:27:15 Generating istio.telemetry.v1alpha1.Telemetry
2024/05/31 14:27:15 Generating istio.networking.v1alpha3.Gateway
mesh/v1alpha1/config.proto:1273:12:Field "59" with name "discovery_selectors" on message "MeshConfig" changed type from "k8s.io.apimachinery.pkg.apis.meta.v1.LabelSelector" to "istio.mesh.v1alpha1.LabelSelector".
make[1]: *** [Makefile.core.mk:53: breaking] Error 100
make: *** [gen] Error 2

@ericvn
Copy link
Contributor

ericvn commented May 31, 2024

/test gencheck

@istio-testing
Copy link
Collaborator

@craigbox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
gencheck_api 0f17807 link true /test gencheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costinm costinm costinm left review comments

@linsun linsun linsun left review comments

@howardjohn howardjohn howardjohn approved these changes

@keithmattix keithmattix keithmattix approved these changes

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

Assignees
No one assigned
Labels
cherrypick/release-1.22 Set this label on a PR to auto-merge it to the release-1.22 branch release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@craigbox @ericvn @istio-testing @costinm @howardjohn @keithmattix @linsun @hzxuzhonghu