HTTP local rate limit #1842
HTTP local rate limit #1842
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
kyessenov
requested review from
dcberg,
duderino,
linsun,
louiscryan,
nrjpoddar and
smawson
as code owners
|
😊 Welcome @kyessenov! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
google-cla
bot
added
the
cla: yes
istio-testing
added
the
size/L
kyessenov
added
the
release-notes-none
|
/assign @bianpengyuan We can use stage 0 for local rate limit (this PR) and stage 1 for global rate limit (follow up). |
Signed-off-by: Kuat Yessenov <kuat@google.com>
| // max_tokens: 100 | ||
| // tokens_per_fill: 100 | ||
| // fill_interval: 1s | ||
| // ``` |
There was a problem hiding this comment.
Thanks !
- either description or example when max tokens and tokens per fill are different? We can point to the envoy documentation or another place as well, but would be good to have basics here.
- Add an example for sidecar to sidecar communication where we want to limit easy source canonical service to a certain amount.
There was a problem hiding this comment.
- It's hard to put in words a custom token bucket (it's a tradeoff between the timer overhead and "smoothness" of request bursts).
- I don't think that's possible with the networking APIs since we need this on the server-side. We might need to copy-paste parts of networking into server-side API like authorization did. The whole networking API assumes a known source already, but it doesn't use "canonical" terminology.
There was a problem hiding this comment.
That is a bummer, also a deal breaker. Ability to ratelimit inter service traffic is one of the main customer asks.
|
@kyessenov: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
istio-testing
added
the
needs-rebase
Expose per-route local rate limiting in HTTP.
Simplified version of Envoy APIs.
Signed-off-by: Kuat Yessenov kuat@google.com