-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to python 3.5+ syntax, add autoformat #11768
Conversation
Hi @alok ! My latest PR changed the iptestcontroller.py file, so you probably need to rebase your local repository. |
Thanks ! I'll try to have a look when I can !
Well we'd love to enforce black, but we don't want to modify all the files at once as it would break some things like |
dc80f99
to
ac357d7
Compare
@Carreau I rebased. Though if you wouldn't mind updating the tests, that would be nice since I have no idea what the mini-language for test case formatting is. |
Not quite sure what mini language you are referring to. Ss this touch ~150 files, I might end up integrating it in multiple step. Did you use a script or changed all by hand ? |
Nevermind, it was an issue that came up with I just ran |
This PR may really break python2.7 compatibility in And it is better to remain PEP461 string formatting unchanged for the target python version is 3.5. |
@drunkwcodes I'm not going to do any of that. 2.7 support has been dropped since 6.0, which came out 2 years ago. |
@alok Fine. But PEP461 formatting? |
What is that
|
@alok That is the proof of unnecessity about the change of string formatting. |
Addresses #11749. If autoformat (done with
black
) is not desired, I can removethat.
If it is desired, then I still need to add it to Travis to enforce that people
use it. One issue is that it requires 3.6+ to run.