fix: increase TTLs for NODATA responses #59
Merged
+60
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minimize the need for returning "NODATA-A/AAAA" responses See: #52
this ensures we ALWAYS control TTL of ACME DNS-01 response and keep it very low (10s here) to ensure "not set" response is not cached for hours due to minimal TTL from SOA
lidel
changed the title
4 tasks
if dynamodb starts returning empty strings, we want to see that reflected in metrics
making sure we always return "empty" txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to close #52 by:
_acme-challengesubdomain with 10s TTL to ensure "not set yet" result is not cached for entire day