chore: use eslint-config-ipfs import sorting #1178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR shows an example of what changes ipfs/eslint-config-ipfs#126 would enforce. All of this these changes (except package.json) were done by running `npm run lint -- --fix`. CALLOUTS: 1. eslint was failing with locally linked package on missing plugins. 1. lint fix was called twice, with the first run failing due to an empty line the first fix runthrough didn't fix. 1. tsc seems to be failing for aegir
It's failing because the automated reordering of imports didn't also move the associated E.g. this used to work: // @ts-expect-error foo-no-types has no types
import foo from 'foo-no-types'
import bar from 'bar-has-types'then with the changes in ipfs/eslint-config-ipfs#126 // @ts-expect-error foo-no-types has no types
import bar from 'bar-has-types'
import foo from 'foo-no-types'so it explodes because the |
whizzzkid
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
LGTM, applying this rule doesn't seem to move associated comments in utils/echo-server.js
https://github.com/ipfs/aegir/actions/runs/4057685025/jobs/6983724772
Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
achingbrain
added a commit
to ipfs/eslint-config-ipfs
that referenced
this pull request
Apr 5, 2023
Lint import sorting, and support auto-fixing of import order. see ipfs/aegir#1178 for an example --------- Co-authored-by: Alex Potsides <alex@achingbrain.net>
achingbrain
added a commit
to ipfs/eslint-config-ipfs
that referenced
this pull request
Apr 5, 2023
Lint import sorting, and support auto-fixing of import order. see ipfs/aegir#1178 for an example --------- Co-authored-by: Alex Potsides <alex@achingbrain.net>
|
Superseded by #1229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows an example of what changes ipfs/eslint-config-ipfs#126
would enforce. All of this these changes (except package.json) were done
by running
npm run lint -- --fix.CALLOUTS:
line the first fix runthrough didn't fix.