Skip to content

refactor(virtual-scroll): deprecate virtual scroll in favor of JS framework solutions #23854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): deprecation

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

@github-actions github-actions bot added the package: core @ionic/core package label Aug 31, 2021
@liamdebeasi liamdebeasi merged commit a0229bc into main Aug 31, 2021
@liamdebeasi liamdebeasi deleted the deprecate-vs branch August 31, 2021 22:20
@avidan-chen
Copy link

avidan-chen commented Sep 3, 2021

Very disappointed in this decision. ion-virtual-scroll is the only component we found to work well with pull to refresh and dynamic sizes (using Angular). With this decision, we are left with no solution for variable height items (we tried to migrate to different open source Angular components, in a process that took more than a few weeks, no component came close to Ionic's implementation, even considereing the open bugs this component has).
In my opinion, given that this is the only solution available for Angular / Ionic developers needing to implement a virtual scroll with variable height items, it would have been preferable to work on the open issues rather than deprecate it and leave us hanging.

@MuhAssar
Copy link

MuhAssar commented Sep 6, 2021

@avidan-chen :
I had a similar experiece like yours, I tried using Angular Materials's virtual-scroll but found that ion-virtual-scroll is a better solution.
@liamdebeasi :
I hope you keep ion-virtual-scroll as a community supported component and call for a volunteer to maintain it.

@elvisgraho
Copy link
Contributor

Been using 'ngx-virtual-scroller' for Angular. Fixed all the issues. The deprecation of ion-virtual-scroll doesn't affect pull to refresh (ion-refresher) at all.

@avidan-chen
Copy link

@elvisgraho
Tried that. Had multiple issues with it, couldn't sort it out. Weird jumps while scrolling, UI didn't always look good. Perhaps we had different layouts to each item, so we got different results. Either way, ion-virtual-scroll was the only one we could get to work with our requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants