-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webkit ios 16.4 enable inspection #677
Webkit ios 16.4 enable inspection #677
Conversation
yes please... found also fork doing the same thing: mochi-cards@8ed55ac |
There's an additional commit from 2021 that includes specific MIME types. IS that needed to set |
Duplicate/partial implementation of apache/cordova-ios#1300
5e5bb96
to
0c49fc4
Compare
@jvjvjv Thanks for the heads up , not sure how/why commit 0c2e273 is injected. Had forked directly from the ionic-team/[master] (https://github.com/ionic-team/cordova-plugin-ionic-webview/) using GH-Web. Have reverted the injected commit for now (as multiple persons seem to be monitoring this PR all ready). The squash merge will solve it but I think the hold up is due to this repo being in hibernation. |
Would be cool if we could get this fix into the next release as fast as possible. :) Can the maintainers please have a look on this? |
This is an important needed fix. I can't properly debug my iOS app now. |
This comment was marked as abuse.
This comment was marked as abuse.
As a workaround I added the following code to the function getWebView() in node_modules/@capacitor/ios/Capacitor/Capacitor/CapacitorBridge.swift
|
I just wanted to say this is the best news ever thank you giralte-ionic! |
The real trick is going to be getting this to publish so please be patient |
Legendary. |
* extension -> mime explicit mapping * Set webView.inspectable to true for debug builds on iOS >= 16.4 Duplicate/partial implementation of apache/cordova-ios#1300 --------- Co-authored-by: Pavel Kurdyukov <kurdyukov.pavel@gmail.com>
* commit 'e591d7c73bf0abe973b7a7eaaf8e95b50c0e5708': update package.json and changelog Webkit ios 16.4 enable inspection (ionic-team#677)
what about ios 16.6 ? cant inspect my ionic cordova app, i tried with cordova-plugin-ionic-webview 5.0.1 |
I'm facing the same issue with iOS 16.7.1 |
* extension -> mime explicit mapping * Set webView.inspectable to true for debug builds on iOS >= 16.4 Duplicate/partial implementation of apache/cordova-ios#1300 --------- Co-authored-by: Pavel Kurdyukov <kurdyukov.pavel@gmail.com>
I have IOS 17.3 and safari TP version 17.4. I can't inspect my ionic cordova application. |
Partial/copy of apache/cordova-ios#1300 credit to @BBosman
Platforms affected
iOS
Motivation and Context
With the introduction of iOS 16.4 WKWebView instances will no longer be inspectable by default.
Details: Enabling the Inspection of Web Content in Apps
Description
This PR honors that change for Release builds, but explicitly sets the inspectability to YES for Debug builds by default.
It also introduce an override option, so consumers can influence this decision in their own build.