Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish migrating to webpack 5 #8309

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Sep 19, 2023

Closes

Enables #8257

Follows #5245

Technical

I followed the guide here: https://webpack.js.org/migrate/5/

We were pretty much already using webpack 5 thanks to #5245 but now we are fully moved over.

Note: I'm pretty sure we have to upgrade vue cli and webpack together because of the dependency.

We did the babel/eslint upgrade in #8312

Testing

Well building works and a quick look at the site thing seem fine.

Stakeholders

@jimchamp @mekarpeles

@RayBB RayBB mentioned this pull request Sep 20, 2023
@mekarpeles
Copy link
Member

I heard on our last staff call that maybe this will be blocked by vue 2->3 and may benefit from Tuesday call discussion

@RayBB
Copy link
Collaborator Author

RayBB commented Sep 25, 2023

@mekarpeles
@vue/cli-service v5 depends on webpack 5 per this. Also v4 of @vue/cli-service doesn't work with webpack 5 so they must be upgraded together.

However, as far as I can tell, this has no impact on vue 2 support and the components compile and work fine.

But I'll try to join the call to better understand the concern.

@codecov-commenter
Copy link

Codecov Report

Merging #8309 (e6c0b2e) into master (126af2b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8309   +/-   ##
=======================================
  Coverage   16.66%   16.66%           
=======================================
  Files          83       83           
  Lines        4422     4422           
  Branches      757      757           
=======================================
  Hits          737      737           
  Misses       3202     3202           
  Partials      483      483           

@jimman2003
Copy link
Contributor

I concur that vue-cli v5 is compatible with vue 2, at least according to the vue 2.6 to 2.7 migration guide

Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tossed this on testing and it built successfully and library explorer and the author identifier component work swimmingly! Lgtm!

@cdrini cdrini merged commit 1205b5f into internetarchive:master Sep 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants