Skip to content

Commit

Permalink
make: lint, mypy disable error code call-arg
Browse files Browse the repository at this point in the history
getting dozens of mypy errors with upgraded pydantic (1.10.6) and mypy
(1.1.1); ...

```
tests/test_transform.py:57: error: Missing named argument "doaj_id" for
"ScholarBiblio"  [call-arg] tests/test_transform.py:57: error: Missing
named argument "dblp_id" for "ScholarBiblio"  [call-arg]
tests/test_transform.py:57: error: Missing named argument "oai_id" for
"ScholarBiblio"  [call-arg]
```

related: pydantic/pydantic#5077

For the moment, try to follow dependency upgrades to not let the gap
become too larget; albeit these issues are time-consuming to sort out.
  • Loading branch information
miku committed Mar 17, 2023
1 parent c3cfa80 commit aa9b74a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Expand Up @@ -17,7 +17,7 @@ dep: ## Install dependencies using pipenv
lint: ## Run lints (eg, flake8, mypy)
pipenv run flake8 fatcat_scholar/ tests/ --exit-zero
pipenv run isort -q -c fatcat_scholar/ tests/ || true
pipenv run mypy fatcat_scholar/ tests/ --ignore-missing-imports
pipenv run mypy fatcat_scholar/ tests/ --ignore-missing-imports --disable-error-code call-arg

.PHONY: pytype
pytype: ## Run slow pytype type check (not part of dev deps)
Expand Down

0 comments on commit aa9b74a

Please sign in to comment.