-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go: bump github.com/cilium/ebpf from 0.12.3 to 0.13.2 #2513
go: bump github.com/cilium/ebpf from 0.12.3 to 0.13.2 #2513
Conversation
4c00e70
to
aca5901
Compare
I had to modify the commit to handle changes done to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to BatchLookup look good to me.
For reference, they are needed due to:
go 1.21 | ||
go 1.21.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slack discussion: https://cilium.slack.com/archives/C027KBX679U/p1708072798219249 & golang/go#62278
aca5901
to
fe1c5c5
Compare
Bumping makes our unit tests explode, I opened a PR upstream to propose a fix about it but this is rather to have a discussion about the underlying issue: cilium/ebpf#1353 |
fe1c5c5
to
c1bd4b2
Compare
c1bd4b2
to
10d75e6
Compare
With the merge of cilium/ebpf#1357 and release of https://github.com/cilium/ebpf/releases/tag/v0.13.2, the problem is fixed upstream. |
10d75e6
to
e73b958
Compare
Bumps [github.com/cilium/ebpf](https://github.com/cilium/ebpf) from 0.12.3 to 0.13.2. - [Release notes](https://github.com/cilium/ebpf/releases) - [Commits](cilium/ebpf@v0.12.3...v0.13.2) --- updated-dependencies: - dependency-name: github.com/cilium/ebpf dependency-type: direct:production update-type: version-update:semver-minor ... This commit also modifies call to BatchLookup() to use new MapBatchCursor type instead of using keys [1, 2]. We also rename all the eBPF objects files and associated golang files [3]. Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com> [1]: cilium/ebpf@583609c0f392 [2]: cilium/ebpf@cc0e5a2479b7 [3]: cilium/ebpf@f95957d1669c
e73b958
to
4ac24c3
Compare
A newer version of github.com/cilium/ebpf exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see tests are passing fine and it LGTM from code inspection.
Thank you for the review! |
Bumps github.com/cilium/ebpf from 0.12.3 to 0.13.2.
Release notes
Sourced from github.com/cilium/ebpf's releases.
... (truncated)
Commits
1cb951a
map: rename BatchCursor to MapBatchCursorb0728bc
fix minor contradiction in comments644fc57
internal: replace internal memoize with sync.OnceValues77874d8
build(deps): bump actions/setup-go from 4 to 5ca24c23
build(deps): bump mkdocs-material from 9.5.6 to 9.5.8 in /docs4503655
build(deps): bump mkdocs-git-revision-date-localized-plugin in /docs80e86d6
build(deps): bump actions/upload-artifact from 3 to 44d619bb
build(deps): bump actions/github-script from 3 to 7a2fd8cc
build(deps): bump actions/setup-python from 4 to 5e8bdb76
use slices and maps packages instead of x/expMost Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)