Skip to content
This repository was archived by the owner on Jul 8, 2023. It is now read-only.

CHEF-3759 Crossport public 6540 Fix for inspec parallel on windows crashing due to error log rename #74

Merged
merged 11 commits into from
Jul 4, 2023
Merged

CHEF-3759 Crossport public 6540 Fix for inspec parallel on windows crashing due to error log rename #74

merged 11 commits into from
Jul 4, 2023
+70 −17

Conversation

clintoncwolfe
Copy link
Contributor

This is a branch-to-branch pull of upstream PR inspec/inspec#6540 . Discussion should occur on that PR.

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

Sorry, something went wrong.

Nik08 and others added 11 commits July 4, 2023 14:58
@Nik08 @clintoncwolfe
Error logging changes to fix renaming of files in windows

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
66b1eb0 
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
@Nik08 @clintoncwolfe
Parallel rename, delete and logging fix for windows
194600b 
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
@Nik08 @clintoncwolfe
Log path changes reverted after testing with static logs directory
ea7a67d 
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
@Vasu1105 @clintoncwolfe
Fix lint
38c59f3 
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
@Nik08 @clintoncwolfe
Logic to rename error log files on interrupt
6c16e86 
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
@Nik08 @clintoncwolfe
An attempt to reduce the delay on control c interrupt by killing chil…
7033b52 
…d process instantly

Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
@Nik08 @clintoncwolfe
Only rename existing file of the child process to avoid conficts in r…
9f9d5be 
…enaming

Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
@Nik08 @clintoncwolfe
Fix in renaming with control-c interrupt by invoking from command lib…
c3fc0d0 
…rary itself

Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
@Nik08 @clintoncwolfe
Added logic to wait for processes to die after process kill, to fix e…
d537cb3 
…rror on interrupt

Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
@Nik08 @clintoncwolfe
Removed idle inititation on status super reporter for parallel - need…
c100d58 
…s future improvements

Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
@Nik08 @clintoncwolfe
Fileutils Mkdir usage refactoring
ab67747 
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
@clintoncwolfe clintoncwolfe requested a review from a team as a code owner July 4, 2023 19:02
@clintoncwolfe clintoncwolfe merged commit 1ecf6bd into inspec-6 Jul 4, 2023
@clintoncwolfe clintoncwolfe deleted the nm/parallel-windows-rename-delete-log-fix branch July 4, 2023 19:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Vasu1105 Vasu1105

@sathish-progress sathish-progress

Assignees

@clintoncwolfe clintoncwolfe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clintoncwolfe @Nik08 @Vasu1105