fix: resolve compiler error for unused dbObj variable in event hooks #311
+71
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seancribbs
force-pushed
the
avoid-unused-dbobj
branch
2 times, most recently
from
ba30229 to
848da0e
Compare
Signed-off-by: Sean Cribbs <seancribbs@gmail.com>
seancribbs
force-pushed
the
avoid-unused-dbobj
branch
from
848da0e to
a7b67ef
Compare
nicolerenee
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dbObjin the deletion event hook is only needed when there are additionalsubject annotations on non-sensitive fields or relations, so I created a template
function to check that condition and wrapped the entire section that processes
those annotations in an
if.