Skip to content

implement #[influxdb(tag)] and #[influxdb(ignore)] #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 17, 2020

Conversation

blasrodri
Copy link
Contributor

Trying to implement this

@blasrodri blasrodri force-pushed the influx-aware-macro-attr branch from 9fec03e to fcaa378 Compare December 16, 2020 17:09

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@msrd0
Copy link
Collaborator

msrd0 commented Dec 16, 2020

Looking at the CI failure, these seem to be your problems:

The first two should be easy to fix, the last error I'm not sure about why that's happening. You can use eprintln! from any macro code to emit debug messages at compile time - try to verify that the variables, especially is_ignored, contain the values you expect them to.

@msrd0 msrd0 changed the title implement #[influx_aware(tag)] and #[influx_aware(ignore)] implement #[influxdb(tag)] and #[influxdb(ignore)] Dec 16, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@blasrodri
Copy link
Contributor Author

Thanks, @msrd0 for your comments. I think I've addressed most of the issues. Unfortunately, the CI is still failing.
Any ideas on how to fix it?

@msrd0
Copy link
Collaborator

msrd0 commented Dec 16, 2020

The error appears here - I'd assume this is because the test is asking for humidity data from the database, which is now an ignored field, and therefore the database does not return any rows?

Copy link
Collaborator

@msrd0 msrd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this!

@msrd0 msrd0 merged commit 614316a into influxdb-rs:master Dec 17, 2020
@Empty2k12
Copy link
Collaborator

Awesome! Thanks for this. Will be releasing a new version with this soon!

@blasrodri blasrodri deleted the influx-aware-macro-attr branch December 17, 2020 16:42
@Empty2k12
Copy link
Collaborator

Hello! I just published a change to crates.io containing your change as version 0.4.0. Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants