Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(kafka): Use dynamic ports with integration tests #14301

Merged
merged 5 commits into from
Nov 17, 2023
Merged

test(kafka): Use dynamic ports with integration tests #14301

merged 5 commits into from
Nov 17, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Nov 15, 2023

This changes both kafka input and output integration tests to use the testcontainers-go kafka module. This allows us to stop using fixed ports which can occasionally collide in CircleCI.

@telegraf-tiger telegraf-tiger bot added the test label Nov 15, 2023
@powersj powersj self-assigned this Nov 16, 2023
@powersj
Copy link
Contributor Author

powersj commented Nov 16, 2023

Waiting on testcontainers/testcontainers-go#1923

@powersj
test: Use dynamic ports with Kafka integration tests
b41b648 
This changes both kafka input and output integration tests to use the
testcontainers-go kafka module. This allows us to stop using fixed ports
which can occasionally collide in CircleCI.
@powersj powersj marked this pull request as ready for review November 16, 2023 14:41
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 16, 2023
@powersj powersj assigned srebhan and unassigned powersj Nov 16, 2023
srebhan
srebhan reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj! Just some naming suggestions...

plugins/inputs/kafka_consumer/kafka_consumer_test.go Outdated Show resolved Hide resolved
plugins/outputs/kafka/kafka_test.go Outdated Show resolved Hide resolved
plugins/inputs/kafka_consumer/kafka_consumer_test.go Outdated Show resolved Hide resolved
@powersj
Copy link
Contributor Author

powersj commented Nov 16, 2023

@srebhan thank you those are much better names ;) PR updated

srebhan
srebhan reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three more (small) comments... Sorry for not catching them on the first pass...

plugins/inputs/kafka_consumer/kafka_consumer_test.go Show resolved Hide resolved
plugins/inputs/kafka_consumer/kafka_consumer_test.go Outdated Show resolved Hide resolved
plugins/outputs/kafka/kafka_test.go Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj!

@srebhan srebhan changed the title test: Use dynamic ports with Kafka integration tests test(kafka): Use dynamic ports with integration tests Nov 17, 2023
@srebhan srebhan added area/kafka plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Nov 17, 2023
@srebhan srebhan merged commit 4c4b821 into influxdata:master Nov 17, 2023
24 checks passed
@github-actions github-actions bot added this to the v1.29.0 milestone Nov 17, 2023
@powersj powersj deleted the test/kafka-dynamic-ports branch November 17, 2023 13:26
@powersj powersj restored the test/kafka-dynamic-ports branch March 29, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/kafka plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. test
Projects
None yet
Milestone
v1.29.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@powersj @srebhan