[#440] Simplify reproducible builds

[tristantarrant]

Closes #440

[pruivo]

There is this "warning" shown at the beginning

[INFO] --- artifact:3.6.0:compare (default-cli) @ parent ---
[ERROR] Reproducible Build not activated by project.build.outputTimestamp property: see https://maven.apache.org/guides/mini/guide-reproducible-builds.html
[ERROR] project.build.outputTimestamp = "${git.commit.time}": isn't Git value set?
[ERROR] Did validate phase run and Git plugin set the value?
[ERROR] if using git-commit-id-plugin, <skipPoms>false</skipPoms> may solve the issue.

Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937)
Maven home: /home/pedro/.opt/jdk/maven
Java version: 23.0.2, vendor: Eclipse Adoptium, runtime: /home/pedro/.opt/jdk/jdk-23.0.2+7
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.13.5-2-manjaro", arch: "amd64", family: "unix"

[pruivo]

Should this be outside the profile? Although we don't need it in the product (AFAIK), it would be nice to have reproducible builds all the time. Just my 2 cents.

[tristantarrant]

Right, I've moved it out of the profile.

[tristantarrant]

@pruivo running the artifact plugin from the command-line by itself is not enough, since it won't run the git-commit-id plugin first. Use:

mvn initialize artifact:check-buildplan

[pruivo]

@pruivo running the artifact plugin from the command-line by itself is not enough, since it won't run the git-commit-id plugin first. Use:

mvn initialize artifact:check-buildplan

If I set <skipPoms>false</skipPoms>, I don't need to add the initalize phase.

[tristantarrant]

https://github.com/infinispan/protostream/pull/441/files#diff-b5a06276719e759fe07dfe6f75d781be5f83d2215179d82bdb195ad035348214R521