IPROTO-62 Implement annotation based schema generation support for 'oneof' #39
+184
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anistor
force-pushed
the
t_IPROTO-62_m
branch
3 times, most recently
from
fbd4e5c to
7a9191c
Compare
anistor
force-pushed
the
t_IPROTO-62_m
branch
2 times, most recently
from
539935e to
7697005
Compare
anistor
force-pushed
the
t_IPROTO-62_m
branch
3 times, most recently
from
eba382f to
144b62c
Compare
anistor
force-pushed
the
t_IPROTO-62_m
branch
2 times, most recently
from
96e6caa to
2eb6dfb
Compare
anistor
force-pushed
the
t_IPROTO-62_m
branch
2 times, most recently
from
a2adcfd to
7d06323
Compare
anistor
force-pushed
the
t_IPROTO-62_m
branch
from
7d06323 to
67db7f7
Compare
anistor
force-pushed
the
t_IPROTO-62_m
branch
3 times, most recently
from
c285c07 to
f78b56d
Compare
anistor
force-pushed
the
t_IPROTO-62_m
branch
4 times, most recently
from
8299684 to
c61c20a
Compare
anistor
force-pushed
the
t_IPROTO-62_m
branch
from
c61c20a to
751c8ce
Compare
anistor
force-pushed
the
t_IPROTO-62_m
branch
2 times, most recently
from
c657d67 to
6865e91
Compare
anistor
force-pushed
the
t_IPROTO-62_m
branch
from
6865e91 to
2ff218f
Compare
anistor
force-pushed
the
t_IPROTO-62_m
branch
from
2ff218f to
52df159
Compare
anistor
force-pushed
the
t_IPROTO-62_m
branch
2 times, most recently
from
2ee1825 to
a7da972
Compare
anistor
force-pushed
the
t_IPROTO-62_m
branch
2 times, most recently
from
eb6523a to
d9c3ae8
Compare
fax4ever
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
+1 to merge it from me.
@tristantarrant I don't know what you think about it
tristantarrant
approved these changes
Aug 3, 2022
|
Merged, thanks |
|
Thank you @tristantarrant and @anistor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/IPROTO-62