-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPROTO-239 Use correct generated class #168
Conversation
4158289
to
45a7954
Compare
@fax4ever the minimum JDK version is 11. Can't we just use the JDK9+ annotation all the time (and probably update the annotation-api dependency)? |
@pruivo we talked about it with Katia but the README seems to indicate you still support a JDK 8 runtime for protostream: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should fix the issue we have with Quarkus, thanks!
The README isn't updated yet (we forgot). Lines 103 to 104 in 9379923
|
OK, well, in this case, we can just switch to the new annotation. That will simplify things for sure :). And maybe update the README too. |
45a7954
to
dffbd56
Compare
dffbd56
to
d8194d4
Compare
Thanks @pruivo and @gsmet for the review. |
Merged, thanks |
Thank you! |
Thanks! |
@fax4ever @tristantarrant @pruivo it would be awesome if you could include this in the next Infinispan 14 dev release! |
https://issues.redhat.com/browse/IPROTO-239