Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the codebase up to PHP 8.1 syntax using Rector #1860

Merged
merged 1 commit into from
May 14, 2023
Merged

Upgrade the codebase up to PHP 8.1 syntax using Rector #1860

merged 1 commit into from
May 14, 2023

Conversation

maks-rafalko
Copy link
Member

  • Use Rector on CI
  • Use Rector as SA tool locally
  • Add Rector to Makefile

github-actions[bot]
github-actions bot requested changes May 14, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

sanmai
sanmai approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@sanmai sanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@maks-rafalko maks-rafalko mentioned this pull request May 14, 2023
Merged
Base automatically changed from feature/upgrade-phpstan to master May 14, 2023 15:49
@maks-rafalko
Upgrade the codebase up to PHP 8.1 syntax using Rector
de987fa 
- Use Rector on CI
- Use Rector as SA tool locally
- Add Rector to Makefile
@maks-rafalko maks-rafalko enabled auto-merge (squash) May 14, 2023 20:07
@maks-rafalko maks-rafalko merged commit b65f59b into master May 14, 2023
40 checks passed
@maks-rafalko maks-rafalko deleted the feature/rector branch May 14, 2023 20:52
@maks-rafalko
Copy link
Member Author

Thank you @sanmai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions requested changes

@sanmai sanmai sanmai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maks-rafalko @sanmai