Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility warning in Svelte Link component #1858

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

reinink
Copy link
Member

@reinink reinink commented Apr 16, 2024

Resolves #1627
Resolves #1635
Resolves #1835

Right now the Svelte adapter is throwing an ARIA warning during build:

Link.svelte:27:0 A11y: <svelte:element> with click, dblclick, mousedown, mousemove, mouseout, mouseover, mouseup handlers must have an ARIA role

While a couple possible solutions have been shared (#1635, #1835), I am pretty sure that this is actually a false positive and a good use case for a svelte-ignore comment, so that's what I've implemented here.

@reinink reinink merged commit 1cc01b2 into master Apr 16, 2024
6 checks passed
@reinink reinink deleted the fix-svelte-lint-warning branch April 16, 2024 12:35
@reinink
Copy link
Member Author

reinink commented Apr 16, 2024

This fix has been released as part of v1.0.16 👍

This was referenced Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 4 warning during build
1 participant